clusterctl: cert-manager doesn't update even if image override has been changed

[dmvolod]

What steps did you take and what happened?

We are using repository image override option in our clusterctl.yaml file as:

images:
  all:
    repository: myorg.io/local-repo

At some point, we may need to change the repository and update all components of the cluster API. We update the clusterctl.yaml file and run the clusterctl upgrade apply command. All providers are updated correctly, but the cert-manager is not updated.

What did you expect to happen?

We expect all components (providers + cert-manager) including deployments image paths to be updated as they are managed from the clustersctl.yaml file directly.

Cluster API version

v1.8.5

Kubernetes version

No response

Anything else you would like to add?

From the point of view of the cert-manager update code, I see that if its version does not change, then the only criterion for updating will be a different number of installed and installing objects, which is not true. In reality, the number of objects are the same, but the images in the Deployments are different. This should be validated in advance, as images can be managed from the clusterctl.yaml file.

Will fix this issue, if it suitable

Label(s) to be applied

/kind bug
/area clusterctl

[k8s-ci-robot]

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.