Skip to content

Commit 6ec734c

Browse files
Update existing AC generator tests
Pass the `externalApplyConfigurations` option to the `applyconfiguration` generator in the other tests so that they correctly generate `ApplyConfiguration` types now that an external type is used in the `CronJob`.
1 parent f5a4a09 commit 6ec734c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/applyconfiguration/applyconfiguration_integration_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ var _ = Describe("ApplyConfiguration generation from API types", func() {
109109
Expect(optionsRegistry.Register(markers.Must(markers.MakeDefinition("applyconfiguration", markers.DescribesPackage, Generator{})))).To(Succeed())
110110

111111
rt, err := genall.FromOptions(optionsRegistry, []string{
112-
"applyconfiguration",
112+
"applyconfiguration:externalApplyConfigurations=sigs.k8s.io/controller-tools/pkg/applyconfiguration/testdata/cronjob/external.ExternalData@sigs.k8s.io/controller-tools/pkg/applyconfiguration/testdata/cronjob/externalac",
113113
"paths=./api/v1",
114114
})
115115
Expect(err).NotTo(HaveOccurred())
@@ -218,7 +218,7 @@ var _ = Describe("ApplyConfiguration generation from API types", func() {
218218

219219
rt, err := genall.FromOptions(optionsRegistry, []string{
220220
"crd:allowDangerousTypes=true,ignoreUnexportedFields=true", // Run another generator first to make sure they don't interfere; see also: the comment on cronjob_types.go:UntypedBlob
221-
"applyconfiguration",
221+
"applyconfiguration:externalApplyConfigurations=sigs.k8s.io/controller-tools/pkg/applyconfiguration/testdata/cronjob/external.ExternalData@sigs.k8s.io/controller-tools/pkg/applyconfiguration/testdata/cronjob/externalac",
222222
"paths=./api/v1",
223223
})
224224
Expect(err).NotTo(HaveOccurred())

0 commit comments

Comments
 (0)