🌱 Fix and test webhook testdata compilation

The webhook testdata used a very old controller-runtime version but
fundamentally doesn't actually need any code, as the tests only require
the markers, so just kill it all.

Author: alvaroaleman

pkg/loader/loader.go

@@ -290,7 +290,10 @@ func (l *loader) typeCheck(pkg *Package) {
 	illTyped := len(errs) > 0
 	if !illTyped {
 		for _, importedPkg := range pkg.Imports() {
-			if importedPkg.IllTyped {
+			importedPkg.Lock()
+			isIllTyped := importedPkg.IllTyped
+			importedPkg.Unlock()
+			if isIllTyped {
 				illTyped = true
 				break
 			}

pkg/webhook/testdata/go.mod

@@ -1,9 +1,29 @@
 module testdata.kubebuilder.io/cronjob
 
-go 1.15
+go 1.25.0
 
 require (
-	k8s.io/api v0.19.2
-	k8s.io/apimachinery v0.19.2
-	sigs.k8s.io/controller-runtime v0.7.0
+	k8s.io/apimachinery v0.35.0
+	sigs.k8s.io/controller-runtime v0.23.1
+)
+
+require (
+	github.com/fxamacker/cbor/v2 v2.9.0 // indirect
+	github.com/go-logr/logr v1.4.3 // indirect
+	github.com/json-iterator/go v1.1.12 // indirect
+	github.com/kr/pretty v0.3.1 // indirect
+	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
+	github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
+	github.com/x448/float16 v0.8.4 // indirect
+	go.yaml.in/yaml/v2 v2.4.3 // indirect
+	golang.org/x/net v0.47.0 // indirect
+	golang.org/x/text v0.31.0 // indirect
+	gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
+	gopkg.in/inf.v0 v0.9.1 // indirect
+	k8s.io/klog/v2 v2.130.1 // indirect
+	k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
+	k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 // indirect
+	sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
+	sigs.k8s.io/randfill v1.0.0 // indirect
+	sigs.k8s.io/structured-merge-diff/v6 v6.3.2-0.20260122202528-d9cc6641c482 // indirect
 )

pkg/webhook/testdata/go.sum

@@ -15,36 +15,6 @@ limitations under the License.
 
 package cronjob
 
-import (
-	"k8s.io/apimachinery/pkg/runtime"
-	ctrl "sigs.k8s.io/controller-runtime"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
-)
-
-func (c *CronJob) SetupWebhookWithManager(mgr ctrl.Manager) error {
-	return ctrl.NewWebhookManagedBy(mgr).
-		For(c).
-		Complete()
-}
-
 // +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10
 // +kubebuilder:webhook:verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=NoneOnDryRun,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
 // +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/mutate-testdata-kubebuilder-io-v1-cronjob,mutating=true,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=default.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
-
-var _ webhook.Defaulter = &CronJob{}
-var _ webhook.Validator = &CronJob{}
-
-func (c *CronJob) Default() {
-}
-
-func (c *CronJob) ValidateCreate() error {
-	return nil
-}
-
-func (c *CronJob) ValidateUpdate(_ runtime.Object) error {
-	return nil
-}
-
-func (c *CronJob) ValidateDelete() error {
-	return nil
-}

pkg/webhook/testdata/invalid-admissionReviewVersionsRequired/cronjob_types.go

@@ -15,38 +15,8 @@ limitations under the License.
 
 package cronjob
 
-import (
-	"k8s.io/apimachinery/pkg/runtime"
-	ctrl "sigs.k8s.io/controller-runtime"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
-)
-
-func (c *CronJob) SetupWebhookWithManager(mgr ctrl.Manager) error {
-	return ctrl.NewWebhookManagedBy(mgr).
-		For(c).
-		Complete()
-}
-
 // +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
 // +kubebuilder:webhook:verbs=create;update,path=/validate-testdata-kubebuilder-io-v1-cronjob,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=NoneOnDryRun,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
 // +kubebuilder:webhook:webhookVersions=v1,verbs=create;update,path=/mutate-testdata-kubebuilder-io-v1-cronjob,mutating=true,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=default.cronjob.testdata.kubebuilder.io,sideEffects=None,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1,reinvocationPolicy=IfNeeded
 // +kubebuilder:webhookconfiguration:mutating=true,name=foo
 // +kubebuilder:webhookconfiguration:mutating=true,name=bar
-
-var _ webhook.Defaulter = &CronJob{}
-var _ webhook.Validator = &CronJob{}
-
-func (c *CronJob) Default() {
-}
-
-func (c *CronJob) ValidateCreate() error {
-	return nil
-}
-
-func (c *CronJob) ValidateUpdate(_ runtime.Object) error {
-	return nil
-}
-
-func (c *CronJob) ValidateDelete() error {
-	return nil
-}

pkg/webhook/testdata/invalid-admissionReviewVersionsRequired/webhook.go

@@ -15,34 +15,4 @@ limitations under the License.
 
 package cronjob
 
-import (
-	"k8s.io/apimachinery/pkg/runtime"
-	ctrl "sigs.k8s.io/controller-runtime"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
-)
-
-func (c *CronJob) SetupWebhookWithManager(mgr ctrl.Manager) error {
-	return ctrl.NewWebhookManagedBy(mgr).
-		For(c).
-		Complete()
-}
-
 // +kubebuilder:webhook:url="https://anothersomewebhook:9443/validate-testdata-kubebuilder-io-v1-cronjob",path="/somepath",verbs=create;update,mutating=false,failurePolicy=fail,matchPolicy=Equivalent,groups=testdata.kubebuilder.io,resources=cronjobs,versions=v1,name=validation.cronjob.testdata.kubebuilder.io,sideEffects=NoneOnDryRun,timeoutSeconds=10,admissionReviewVersions=v1;v1beta1
-
-var _ webhook.Defaulter = &CronJob{}
-var _ webhook.Validator = &CronJob{}
-
-func (c *CronJob) Default() {
-}
-
-func (c *CronJob) ValidateCreate() error {
-	return nil
-}
-
-func (c *CronJob) ValidateUpdate(_ runtime.Object) error {
-	return nil
-}
-
-func (c *CronJob) ValidateDelete() error {
-	return nil
-}