From c0a1c30036519723f5a7f351a26c4aa3e31dcef8 Mon Sep 17 00:00:00 2001
From: "Dr. Jan-Philip Gehrcke" <jgehrcke@nvidia.com>
Date: Sun, 14 Sep 2025 17:31:07 +0000
Subject: [PATCH] Add notes about re-adding "v" pfx to chart appVersion
Signed-off-by: Dr. Jan-Philip Gehrcke <jgehrcke@nvidia.com>
---
deployments/helm/nvidia-dra-driver-gpu/Chart.yaml | 1 +
deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl | 3 +++
2 files changed, 4 insertions(+)
diff --git a/deployments/helm/nvidia-dra-driver-gpu/Chart.yaml b/deployments/helm/nvidia-dra-driver-gpu/Chart.yaml
index a589a4efa..1b4f4d2a7 100644
--- a/deployments/helm/nvidia-dra-driver-gpu/Chart.yaml
+++ b/deployments/helm/nvidia-dra-driver-gpu/Chart.yaml
@@ -25,6 +25,7 @@ version: "25.8.0-dev"
# `tag` value used in a k8s image specification. That logic expects the version
# number below to not have a "v" prefix (a "v" is added by said logic to yield a
# valid image reference).
+# TODO: re-add v prefix here (that seems to be more canonical).
appVersion: "25.8.0-dev"
# The kubeVersion puts constraints on the Kubernetes versions where this helm
diff --git a/deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl b/deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl
index dbe178a2f..df0e02f2e 100644
--- a/deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl
+++ b/deployments/helm/nvidia-dra-driver-gpu/templates/_helpers.tpl
@@ -90,6 +90,9 @@ fail "selectorLabels: both arguments are required: context, componentName"
{{/*
Full image name with tag
+TODO:
+- remove `v` here, and add this back to appVersion instead
+- do not overload `tag` to contain both image name and version tag.
*/}}
{{- define "nvidia-dra-driver-gpu.fullimage" -}}
{{- $tag := printf "v%s" .Chart.AppVersion }}
see c0a1c30#r2355758344