Skip to content

Inconsistencies in the template syntax of the inferencepool's Helm chart. #1983

@delavet

Description

@delavet

Currently, in the Helm chart of inferencepool, there are some Helm template syntaxes that have the same practical effect but are written differently. At present, there doesn't seem to be any clear necessity for using different syntaxes. This is not a usability issue, but it does introduce some challenges for project maintenance and PR reviews.
For reference, examples are provided below:

why do we do here:
{{- toYaml .Values.inferenceExtension.volumes | nindent 6 }} (toYaml at the beginning)
and in the configmap:
{{- .Values.inferenceExtension.sidecar.configMapData | toYaml | nindent 2 }} (toYaml after pipelining)?
not a blocker, asking out of curiosity and trying to understand if there is a reason for being inconsistent.

Originally posted by @nirrozenbaum in #1945 (comment)

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions