generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 218
Open
Labels
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.
Description
What would you like to be added:
Consider refactoring pkg/epp/handlers/RequestContext. Currently, it is a monolithic struct containing:
- Envoy External Proc protocol fields (
reqHeaderResp,respBodyResp) - Request metadata (
IncomingModelName) - Lifecycle state (
RequestRunning,ResponseComplete,TargetPod)
Why is this needed:
As noted in the code TODO, this object exposes too much data to too many layers. As we add complex features, the lack of isolation makes it difficult to reason about the request lifecycle state machine.
We should split this into:
ProtocolContext: Handles the gRPC/Envoy interaction.RequestState: Tracks the logical request lifecycle (Start/End times, Pod assignment).
Metadata
Metadata
Assignees
Labels
needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.