Skip to content

Commit 2ad4863

Browse files
authored
Fix incorrect spec change for Policy objects (#4304)
This commit fixes a change made in error to the XBackendTrafficPolicy object, and moves that change to the BackendTLSPolicy object. The change in question marks the supported number of targetRefs for BackendTLSPolicy as one, until we can talk through edge cases in targetRef handling and status updates. Signed-off-by: Nick Young <[email protected]>
1 parent b348130 commit 2ad4863

File tree

6 files changed

+32
-10
lines changed

6 files changed

+32
-10
lines changed

apis/v1/backendtlspolicy_types.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,12 @@ type BackendTLSPolicySpec struct {
8888
// implementation MUST ensure the `Accepted` Condition is set to
8989
// `status: False`, with Reason `Conflicted`.
9090
//
91+
// Implementations SHOULD NOT support more than one targetRef at this
92+
// time. Although the API technically allows for this, the current guidance
93+
// for conflict resolution and status handling is lacking. Until that can be
94+
// clarified in a future release, the safest approach is to support a single
95+
// targetRef.
96+
//
9197
// Support: Extended for Kubernetes Service
9298
//
9399
// Support: Implementation-specific for any other resource

apisx/v1alpha1/xbackendtrafficpolicy_types.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ type BackendTrafficPolicySpec struct {
6969
// Currently, a TargetRef can not be scoped to a specific port on a
7070
// Service.
7171
//
72-
// Because of concerns over recording status correctly in some edge cases,
73-
// currently, Core support is only given to one (1) TargetRef. More than
74-
// one TargetRef is Implementation Specific.
75-
//
7672
// +listType=map
7773
// +listMapKey=group
7874
// +listMapKey=kind

config/crd/experimental/gateway.networking.k8s.io_backendtlspolicies.yaml

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/experimental/gateway.networking.x-k8s.io_xbackendtrafficpolicies.yaml

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/standard/gateway.networking.k8s.io_backendtlspolicies.yaml

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/openapi/zz_generated.openapi.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)