Skip to content

Fix apidoc for attachedRoutes and add conformance test #4321

@rikatz

Description

@rikatz

What happened:

During the implementation of ListenerSet and attachedListener field (#4286) we have identified that the description of gateway.status.listenerStatus.attachedRoutes we have identified that the description does not reflect the reality.

Our description says:

//the AttachedRoutes field count MUST be set
// for Listeners with condition Accepted: false and MUST count successfully
// attached Routes that may themselves have Accepted: false conditions.

but the fact is that at least for Istio, kgateway, envoy gateway and Cilium this count represents Accepted = true

This does make sense, as we need to know what are just the valid routes. And ListenerSet is already reflecting this new behavior.

What you expected to happen:

  • Fix the API description to count only Accepted routes
  • Create a conformance test to validate this behavior

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions