Skip to content

Make the build chain container runtime engine agnostic #4345

@davidesalerno

Description

@davidesalerno

What happened:

A contributor that would like to use a container engine different from docker could experience some issues.

Even if in the Makefile there is the chance to switch to a different container engine setting DOCKER = <your preferred container engine> in other bash scripts referenced into the Makefile this is not possible (i.e. build-and-push.sh and verify-docker-build.sh)

What you expected to happen:

Having the chance to select the preferred container runtime engine setting an envoriment variable that will be used across all the scripts (i.e. BUILDER = docker or CONTAINER_ENGINE = docker ) in the build chain

How to reproduce it (as minimally and precisely as possible):

If you have got a different container runtime engine than docker on your workstation and you try to execute a make it will fail with error

'docker' is not recognized as an internal or external command

Anything else we need to know?:

It will nice to replace all the occurrence to docker in the file name to something like BUILDER or CONTAINER_ENGINE

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions