Skip to content

Expected behaviour when testing Weighted Distribution #4555

@dawid-nowak

Description

@dawid-nowak

It is more a question about the expected behaviour of weighed distribution tests... and particularly around handling errors.

So if my understanding is correct of this https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/weight/weight.go#L77-L102 is correct:

  1. We will kick off totalRequests to the gateway
  2. On response we update seen
  3. And then wait for the group to complete...

It also looks that if any of the go routines returns an error, the remaining logic of this method especially where we compare weights will be skipped and the test will fail.

Just wonder if this is a design intent or a problem?

For example, let's say that one of those totalRequests has failed and all other passed. In theory, the received distrbution could still be within the tolerance ranges of expected distrbution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/conformance-testIssues or PRs related to Conformance tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions