generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 668
Open
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.
Description
It is more a question about the expected behaviour of weighed distribution tests... and particularly around handling errors.
So if my understanding is correct of this https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/weight/weight.go#L77-L102 is correct:
- We will kick off
totalRequeststo the gateway - On response we update
seen - And then wait for the group to complete...
It also looks that if any of the go routines returns an error, the remaining logic of this method especially where we compare weights will be skipped and the test will fail.
Just wonder if this is a design intent or a problem?
For example, let's say that one of those totalRequests has failed and all other passed. In theory, the received distrbution could still be within the tolerance ranges of expected distrbution.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/conformance-testIssues or PRs related to Conformance tests.Issues or PRs related to Conformance tests.