Skip to content

Commit 372ff2c

Browse files
authored
Merge pull request #2678 from headlamp-k8s/fix-table-select-all-checkbox
frontend: Fix memoization for Head cell when selecting all rows
2 parents b36a259 + 15ae14b commit 372ff2c

File tree

1 file changed

+2
-8
lines changed
  • frontend/src/components/common/Table

1 file changed

+2
-8
lines changed

frontend/src/components/common/Table/Table.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -369,13 +369,7 @@ export default function Table<RowItem extends Record<string, any>>({
369369
isFiltered={header.column.getIsFiltered()}
370370
sorting={header.column.getIsSorted()}
371371
showColumnFilters={table.getState().showColumnFilters}
372-
selected={
373-
table.getIsAllRowsSelected()
374-
? 'all'
375-
: table.getIsSomeRowsSelected()
376-
? 'some'
377-
: 'none'
378-
}
372+
selected={table.getSelectedRowModel().flatRows.length}
379373
/>
380374
))}
381375
</StyledHeadRow>
@@ -400,7 +394,7 @@ const MemoHeadCell = memo(
400394
header: MRT_Header<any>;
401395
sorting: string | false;
402396
isFiltered: boolean;
403-
selected: any;
397+
selected: number;
404398
showColumnFilters: boolean;
405399
}) => {
406400
return (

0 commit comments

Comments
 (0)