Merge pull request #4634 from mahmoudmagdy1-1/clusterchooserpopup-scrollable

illume · web-flow · commit 44ea5cf3d24c · 2026-02-07T19:45:12.000-03:00
frontend: Add tabIndex to scrollable cluster list
diff --git a/frontend/src/components/cluster/ClusterChooserPopup.tsx b/frontend/src/components/cluster/ClusterChooserPopup.tsx
@@ -257,6 +257,7 @@ function ClusterChooserPopup(props: ChooserPopupPros) {
         />
         <MenuList
           id="cluster-chooser-list"
+          tabIndex={0}
           sx={{
             width: '280px',
             minWidth: '280px',
diff --git a/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.NoClustersButRecent.stories.storyshot b/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.NoClustersButRecent.stories.storyshot
@@ -69,7 +69,7 @@
           class="MuiList-root MuiList-padding MuiList-dense css-1k1lw4j-MuiList-root"
           id="cluster-chooser-list"
           role="menu"
-          tabindex="-1"
+          tabindex="0"
         >
           <li
             class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-aom5s3-MuiButtonBase-root-MuiMenuItem-root"
diff --git a/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.NoRecentClusters.stories.storyshot b/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.NoRecentClusters.stories.storyshot
@@ -69,7 +69,7 @@
           class="MuiList-root MuiList-padding MuiList-dense css-1k1lw4j-MuiList-root"
           id="cluster-chooser-list"
           role="menu"
-          tabindex="-1"
+          tabindex="0"
         >
           <li
             class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-aom5s3-MuiButtonBase-root-MuiMenuItem-root"
diff --git a/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.Normal.stories.storyshot b/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.Normal.stories.storyshot
@@ -69,7 +69,7 @@
           class="MuiList-root MuiList-padding MuiList-dense css-1k1lw4j-MuiList-root"
           id="cluster-chooser-list"
           role="menu"
-          tabindex="-1"
+          tabindex="0"
         >
           <li
             class="MuiListSubheader-root MuiListSubheader-gutters css-1ac4l9u-MuiListSubheader-root"
diff --git a/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.Scrollbar.stories.storyshot b/frontend/src/components/cluster/__snapshots__/ClusterChooserPopup.Scrollbar.stories.storyshot
@@ -69,7 +69,7 @@
           class="MuiList-root MuiList-padding MuiList-dense css-1k1lw4j-MuiList-root"
           id="cluster-chooser-list"
           role="menu"
-          tabindex="-1"
+          tabindex="0"
         >
           <li
             class="MuiListSubheader-root MuiListSubheader-gutters css-1ac4l9u-MuiListSubheader-root"

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@`
`69`	`69`	`class="MuiList-root MuiList-padding MuiList-dense css-1k1lw4j-MuiList-root"`
`70`	`70`	`id="cluster-chooser-list"`
`71`	`71`	`role="menu"`
`72`		`- tabindex="-1"`
	`72`	`+ tabindex="0"`
`73`	`73`	`>`
`74`	`74`	`<li`
`75`	`75`	`class="MuiButtonBase-root MuiMenuItem-root MuiMenuItem-gutters MuiMenuItem-root MuiMenuItem-gutters css-aom5s3-MuiButtonBase-root-MuiMenuItem-root"`