Merge pull request #4276 from illume/watch-loop

app: backend: Fix for plugin watch doing a loop on mac app

Author: illume

app/electron/plugin-management.ts

@@ -1076,10 +1076,15 @@ export function getPluginBinDirectories(pluginsDir: string): string[] {
             for (const file of files) {
               const filePath = path.join(binDir, file);
               // Skip directories
-              if (fs.statSync(filePath).isDirectory()) {
+              const stat = fs.statSync(filePath);
+              if (stat.isDirectory()) {
                 continue;
               }
-              fs.chmodSync(filePath, 0o755); // rwx r-x r-x
+              const currentMode = stat.mode & 0o777;
+              if (currentMode !== 0o755) {
+                console.log(`Setting executable permissions for ${filePath}`);
+                fs.chmodSync(filePath, 0o755); // rwx r-x r-x
+              }
             }
           } catch (err) {
             console.error(`Error setting executable permissions in ${binDir}:`, err);

backend/pkg/plugins/plugins.go

@@ -377,7 +377,13 @@ func canSendRefresh(c cache.Cache[interface{}]) bool {
 func HandlePluginEvents(staticPluginDir, userPluginDir, pluginDir string,
 	notify <-chan string, cache cache.Cache[interface{}],
 ) {
-	for range notify {
+	for event := range notify {
+		// Skip CHMOD events to avoid looping on electron when user-plugins folder is watched
+		// these events are not relevant to see if plugins have changed.
+		if strings.HasSuffix(event, "CHMOD") {
+			continue
+		}
+
 		// Set the refresh signal only if we cannot send it. We prevent it here
 		// because we only want to send refresh signals that *happen after* we are
 		// allowed to send them.