app: electron: Report rejected command exits

Notify renderer callers when validation, permission, or consent rejects a
command so command processes do not remain pending.

Co-authored-by: René Dudfield <renedudfield@microsoft.com>

Author: tejhan

app/e2e-tests/tests/runCommand.spec.ts

@@ -47,6 +47,19 @@ test.describe('run command', () => {
   });
 
   test('rejects invalid commands from the renderer', async () => {
+    const exitCode = electronPage.evaluate(() => {
+      return new Promise<number>(resolve => {
+        const removeListener = window.desktopApi.receive(
+          'command-exit',
+          (commandId: string, code: number) => {
+            if (commandId === 'invalid-command-e2e') {
+              removeListener();
+              resolve(code);
+            }
+          }
+        );
+      });
+    });
     const rejection = electronApp.waitForEvent('console', {
       predicate: message => message.text().includes('Invalid command: invalid-command'),
     });
@@ -62,5 +75,6 @@ test.describe('run command', () => {
     });
 
     await expect(rejection).resolves.toBeDefined();
+    await expect(exitCode).resolves.toBe(-1);
   });
 });

app/electron/runCmd.test.ts

@@ -319,6 +319,69 @@ describe('handleRunCommand', () => {
     expect(spawnMock).not.toHaveBeenCalled();
   });
 
+  it('reports an exit when command data is invalid', async () => {
+    await handleRunCommand(
+      fakeEvent,
+      {
+        id: 'invalid-command',
+        command: 'not-allowed',
+        args: [],
+        options: {},
+        permissionSecrets: {},
+      },
+      { id: 1 } as any,
+      {}
+    );
+
+    expect(sentMessages).toContainEqual(['command-exit', 'invalid-command', -1]);
+    expect(spawnMock).not.toHaveBeenCalled();
+  });
+
+  it('does not report an invalid command exit without a string ID', async () => {
+    await handleRunCommand(fakeEvent, { command: 'not-allowed' }, { id: 1 } as any, {});
+
+    expect(sentMessages).toEqual([]);
+    expect(spawnMock).not.toHaveBeenCalled();
+  });
+
+  it('reports an exit when the permission secret is rejected', async () => {
+    await handleRunCommand(
+      fakeEvent,
+      {
+        id: 'permission-denied',
+        command: 'gh',
+        args: ['auth', 'status'],
+        options: {},
+        permissionSecrets: { 'runCmd-gh': 1 },
+      },
+      { id: 1 } as any,
+      { 'runCmd-gh': 2 }
+    );
+
+    expect(sentMessages).toContainEqual(['command-exit', 'permission-denied', -2]);
+    expect(spawnMock).not.toHaveBeenCalled();
+  });
+
+  it('reports an exit when the user denies command consent', async () => {
+    loadSettingsMock.mockReturnValue({ confirmedCommands: { 'minikube status': false } });
+
+    await handleRunCommand(
+      fakeEvent,
+      {
+        id: 'consent-denied',
+        command: 'minikube',
+        args: ['status'],
+        options: {},
+        permissionSecrets: { 'runCmd-minikube': 1 },
+      },
+      { id: 1 } as any,
+      { 'runCmd-minikube': 1 }
+    );
+
+    expect(sentMessages).toContainEqual(['command-exit', 'consent-denied', -3]);
+    expect(spawnMock).not.toHaveBeenCalled();
+  });
+
   it('runs gh with the login-shell environment and reports child errors', async () => {
     const fakeMainWindow = { id: 1 } as any;
     const permissionSecrets = { 'runCmd-gh': 99 };

app/electron/runCmd.ts

@@ -279,17 +279,22 @@ export async function handleRunCommand(
   const [isValid, errorMessage] = validateCommandData(eventData);
   if (!isValid) {
     console.error(errorMessage);
+    if (typeof eventData?.id === 'string') {
+      event.sender.send('command-exit', eventData.id, -1);
+    }
     return;
   }
   const commandData = eventData as CommandData;
 
   const [permissionsValid, permissionError] = checkPermissionSecret(commandData, permissionSecrets);
   if (!permissionsValid) {
     console.error(permissionError);
+    event.sender.send('command-exit', commandData.id, -2);
     return;
   }
 
   if (!checkCommandConsent(commandData.command, commandData.args, mainWindow)) {
+    event.sender.send('command-exit', commandData.id, -3);
     return;
   }