Skip to content

Commit e3851fd

Browse files
cacaricoclaude
andcommitted
charts: update docs and tests for reduced permissions
Update README.md to reflect new default clusterRoleName of "view" instead of "cluster-admin". Update all test expected templates to use the new ClusterRoleBinding name "headlamp" (removed -admin suffix) and roleRef name "view" instead of "cluster-admin". Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 4c98764 commit e3851fd

20 files changed

+39
-39
lines changed

charts/headlamp/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ config:
148148
| serviceAccount.name | string | `""` | Service account name |
149149
| serviceAccount.annotations | object | `{}` | Service account annotations |
150150
| clusterRoleBinding.create | bool | `true` | Create cluster role binding |
151-
| clusterRoleBinding.clusterRoleName | string | `"cluster-admin"` | Kubernetes ClusterRole name |
151+
| clusterRoleBinding.clusterRoleName | string | `"view"` | Kubernetes ClusterRole name |
152152
| clusterRoleBinding.annotations | object | `{}` | Cluster role binding annotations |
153153
| podSecurityContext | object | `{}` | Pod security context (e.g., fsGroup: 2000) |
154154
| securityContext.runAsNonRoot | bool | `true` | Run container as non-root |

charts/headlamp/tests/expected_templates/azure-oidc-with-validators.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ metadata:
1616
apiVersion: rbac.authorization.k8s.io/v1
1717
kind: ClusterRoleBinding
1818
metadata:
19-
name: headlamp-admin
19+
name: headlamp
2020
labels:
2121
helm.sh/chart: headlamp-0.39.0
2222
app.kubernetes.io/name: headlamp
@@ -26,7 +26,7 @@ metadata:
2626
roleRef:
2727
apiGroup: rbac.authorization.k8s.io
2828
kind: ClusterRole
29-
name: cluster-admin
29+
name: view
3030
subjects:
3131
- kind: ServiceAccount
3232
name: headlamp

charts/headlamp/tests/expected_templates/default.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ data:
2525
apiVersion: rbac.authorization.k8s.io/v1
2626
kind: ClusterRoleBinding
2727
metadata:
28-
name: headlamp-admin
28+
name: headlamp
2929
labels:
3030
helm.sh/chart: headlamp-0.39.0
3131
app.kubernetes.io/name: headlamp
@@ -35,7 +35,7 @@ metadata:
3535
roleRef:
3636
apiGroup: rbac.authorization.k8s.io
3737
kind: ClusterRole
38-
name: cluster-admin
38+
name: view
3939
subjects:
4040
- kind: ServiceAccount
4141
name: headlamp

charts/headlamp/tests/expected_templates/extra-args.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ data:
2525
apiVersion: rbac.authorization.k8s.io/v1
2626
kind: ClusterRoleBinding
2727
metadata:
28-
name: headlamp-admin
28+
name: headlamp
2929
labels:
3030
helm.sh/chart: headlamp-0.39.0
3131
app.kubernetes.io/name: headlamp
@@ -35,7 +35,7 @@ metadata:
3535
roleRef:
3636
apiGroup: rbac.authorization.k8s.io
3737
kind: ClusterRole
38-
name: cluster-admin
38+
name: view
3939
subjects:
4040
- kind: ServiceAccount
4141
name: headlamp

charts/headlamp/tests/expected_templates/extra-manifests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ data:
4242
apiVersion: rbac.authorization.k8s.io/v1
4343
kind: ClusterRoleBinding
4444
metadata:
45-
name: headlamp-admin
45+
name: headlamp
4646
labels:
4747
helm.sh/chart: headlamp-0.39.0
4848
app.kubernetes.io/name: headlamp
@@ -52,7 +52,7 @@ metadata:
5252
roleRef:
5353
apiGroup: rbac.authorization.k8s.io
5454
kind: ClusterRole
55-
name: cluster-admin
55+
name: view
5656
subjects:
5757
- kind: ServiceAccount
5858
name: headlamp

charts/headlamp/tests/expected_templates/me-user-info-url-directly.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ data:
2525
apiVersion: rbac.authorization.k8s.io/v1
2626
kind: ClusterRoleBinding
2727
metadata:
28-
name: headlamp-admin
28+
name: headlamp
2929
labels:
3030
helm.sh/chart: headlamp-0.39.0
3131
app.kubernetes.io/name: headlamp
@@ -35,7 +35,7 @@ metadata:
3535
roleRef:
3636
apiGroup: rbac.authorization.k8s.io
3737
kind: ClusterRole
38-
name: cluster-admin
38+
name: view
3939
subjects:
4040
- kind: ServiceAccount
4141
name: headlamp

charts/headlamp/tests/expected_templates/me-user-info-url.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ data:
2525
apiVersion: rbac.authorization.k8s.io/v1
2626
kind: ClusterRoleBinding
2727
metadata:
28-
name: headlamp-admin
28+
name: headlamp
2929
labels:
3030
helm.sh/chart: headlamp-0.39.0
3131
app.kubernetes.io/name: headlamp
@@ -35,7 +35,7 @@ metadata:
3535
roleRef:
3636
apiGroup: rbac.authorization.k8s.io
3737
kind: ClusterRole
38-
name: cluster-admin
38+
name: view
3939
subjects:
4040
- kind: ServiceAccount
4141
name: headlamp

charts/headlamp/tests/expected_templates/namespace-override-oidc-create-secret.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ data:
2929
apiVersion: rbac.authorization.k8s.io/v1
3030
kind: ClusterRoleBinding
3131
metadata:
32-
name: headlamp-admin
32+
name: headlamp
3333
labels:
3434
helm.sh/chart: headlamp-0.39.0
3535
app.kubernetes.io/name: headlamp
@@ -39,7 +39,7 @@ metadata:
3939
roleRef:
4040
apiGroup: rbac.authorization.k8s.io
4141
kind: ClusterRole
42-
name: cluster-admin
42+
name: view
4343
subjects:
4444
- kind: ServiceAccount
4545
name: headlamp

charts/headlamp/tests/expected_templates/namespace-override.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ data:
2525
apiVersion: rbac.authorization.k8s.io/v1
2626
kind: ClusterRoleBinding
2727
metadata:
28-
name: headlamp-admin
28+
name: headlamp
2929
labels:
3030
helm.sh/chart: headlamp-0.39.0
3131
app.kubernetes.io/name: headlamp
@@ -35,7 +35,7 @@ metadata:
3535
roleRef:
3636
apiGroup: rbac.authorization.k8s.io
3737
kind: ClusterRole
38-
name: cluster-admin
38+
name: view
3939
subjects:
4040
- kind: ServiceAccount
4141
name: headlamp

charts/headlamp/tests/expected_templates/non-azure-oidc.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ metadata:
1616
apiVersion: rbac.authorization.k8s.io/v1
1717
kind: ClusterRoleBinding
1818
metadata:
19-
name: headlamp-admin
19+
name: headlamp
2020
labels:
2121
helm.sh/chart: headlamp-0.39.0
2222
app.kubernetes.io/name: headlamp
@@ -26,7 +26,7 @@ metadata:
2626
roleRef:
2727
apiGroup: rbac.authorization.k8s.io
2828
kind: ClusterRole
29-
name: cluster-admin
29+
name: view
3030
subjects:
3131
- kind: ServiceAccount
3232
name: headlamp

0 commit comments

Comments
 (0)