Skip to content

Commit e7eb6a6

Browse files
committed
frontend: fix plugin settings props not passed
Always pass data and onDataChange props to plugin settings components, regardless of the displaySaveButton setting. This fixes a bug where these props were only passed when the save button was displayed. Signed-off-by: alokdangre <alokdangre@gmail.com>
1 parent d9a3326 commit e7eb6a6

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

frontend/src/components/App/PluginSettings/PluginSettingsDetails.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,11 +223,7 @@ export function PluginSettingsDetailsPure(props: PluginSettingsDetailsPureProps)
223223
component = plugin.settingsComponent;
224224
} else if (typeof plugin.settingsComponent === 'function') {
225225
const Comp = plugin.settingsComponent;
226-
if (plugin.displaySettingsComponentWithSaveButton) {
227-
component = <Comp onDataChange={onDataChange} data={data} />;
228-
} else {
229-
component = <Comp />;
230-
}
226+
component = <Comp onDataChange={onDataChange} data={data} />;
231227
} else {
232228
component = null;
233229
}

0 commit comments

Comments
 (0)