Skip to content

plugin bundling scripts need to check checksum when downloading #2539

Open
@illume

Description

@illume

Describe the bug

There are some plugin bundling scripts for the app and the container image which download plugins without checking their checksums. The risk is that some files might be corrupted or changed.

Related files:

  • build-manifest.json
  • app-build-manifest.json
  • app/scripts/setup-plugins.js
  • container/fetch-plugins.sh

Probably there are other files that call these.

The package command generates a sha256 checksum, so probably we should use that?

We might want to think of this holistically as being part of the publishing process.

Additional Context

Probably this functionality should live in headlamp-plugin. Currently it's in two different scripts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    headlamp-pluginRelated to the headlamp-plugin NPM package.kind/bugCategorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.pluginsreleaseRelated to releasingsecurity

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions