-
Notifications
You must be signed in to change notification settings - Fork 606
Description
When I am navigating Headlamp and adjusting the number of rows displayed per page,
I want my selected "Rows per page" setting to persist across page reloads and menu navigation,
so I don’t have to repeatedly change it, and when I share my view it shows them the same number of rows.
Discussion
It seems we had this in SimpleTable before, but that functionality got lost.
We do have the settings option... but is it discoverable? Is not the rows per page selector also a setting?
In some other apps this setting is remembered. You don't need to go to a separate settings page to make sure it remembers your rows per page setting.
Additionally, browsers when reloading remember the items in the form. Our implementation of Table forgets rows per page on page reload.
Should rows per page be in the URL? I think so. Because it will change what is shown, and we want people be able to share what they are seeing by sharing URLs. We didn't have this before, and it would complicate the code.
Additional context
- Material react table docs on pagination: https://www.material-react-table.com/docs/guides/pagination
- [RFE] Allow to set a custom number of rows per page for the tables #553
- requested in [RFE] Sticky/Customizable number of rows per page #522
- implemented in SimpleTable frontend: Make the rows-per-page setting persist among views #525
- This was also a popular dashboard feature request: UI enhancement: Rows per page kubernetes-retired/dashboard#1387
Metadata
Metadata
Assignees
Labels
Type
Projects
Status