Skip to content

ci: workflow: add helm e2e tests for plugin manager#4648

Open
Vaishnav-Dhaval wants to merge 1 commit intokubernetes-sigs:mainfrom
Vaishnav-Dhaval:fix/issue-4058
Open

ci: workflow: add helm e2e tests for plugin manager#4648
Vaishnav-Dhaval wants to merge 1 commit intokubernetes-sigs:mainfrom
Vaishnav-Dhaval:fix/issue-4058

Conversation

@Vaishnav-Dhaval
Copy link
Contributor

@Vaishnav-Dhaval Vaishnav-Dhaval commented Feb 8, 2026

Summary

This PR adds Helm e2e tests for plugins repo plugins installed via Helm.

Related Issue

Fixes #4058

Changes

  • added e2e-tests/tests/helmPlugins.spec.ts to verify plugins installed via Helm and Manager.
  • added tableContains helper method to e2e-tests/tests/headlampPage.ts for table content assertions.
  • Updated .github/workflows/build-container.yml to:
    • Set up Helm in the CI environment.
    • Deploy Headlamp using the local chart in a dedicated namespace (headlamp-helm).
    • Configure the Plugin Manager via Helm values to install the Flux plugin from Artifact Hub.
    • Execute the new e2e test against the Helm-installed instance.

Steps to Test

  1. Trigger the "Build Container and test" workflow in GitHub Actions.
  2. In the build discover and deploy job, check the "Deploy Headlamp via Helm and run plugin manager tests" step.
  3. Verify that the helmPlugins.spec.ts test passes, confirming that the Flux plugin is visible in the settings table.

Notes for the Reviewer

  • The test uses the Flux plugin from Artifact Hub as a stable, official reference for integration testing.
  • I've used a 60-second timeout for the plugin check in the e2e test. This is necessary because the Plugin Manager sidecar needs time to download, extract, and initialize the plugin after the pod starts.
  • The Helm deployment uses a NodePort service and a custom baseURL (/headlamp-helm) to ensure routing works correctly in complex deployment scenarios.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vaishnav-Dhaval
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2026
@illume illume requested a review from Copilot February 8, 2026 12:22
Copilot AI reviewed Feb 8, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI coverage for Helm-based deployments by installing Headlamp via the local Helm chart with the Plugin Manager enabled, then running a new Playwright e2e test to validate a plugin installed in-cluster is visible in the UI.

Changes:

  • Add a new Playwright spec (helmPlugins.spec.ts) to verify a Helm+Plugin Manager installed plugin appears in Settings → Plugins.
  • Add a tableContains helper to HeadlampPage for table text assertions.
  • Extend build-container.yml to install Helm, deploy the local chart into a dedicated namespace, and run the new e2e test against that instance.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
e2e-tests/tests/helmPlugins.spec.ts New e2e test targeting Helm-installed Headlamp + plugin manager behavior.
e2e-tests/tests/headlampPage.ts Adds a helper to assert table contents in Playwright tests.
.github/workflows/build-container.yml Adds Helm setup + chart install and runs the new Helm plugin-manager e2e test in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

illume
illume requested changes Feb 8, 2026
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the test is failing in CI. Can you please have a look?

illume
illume requested changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please address the open review comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@illume illume illume requested changes

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

helm e2e tests for our plugins repo plugins installed via helm and Plugin Manager

3 participants

@Vaishnav-Dhaval @k8s-ci-robot @illume