Skip to content

Commit 74db16d

Browse files
committed
fix rebase errors 8
1 parent dd850c3 commit 74db16d

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

inference_perf/reportgen/base.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,7 @@ def calculate_slo_metrics(
103103
if ttft is not None:
104104
ttft_met = (ttft <= m.ttft_slo_sec)
105105
else:
106-
# If it's not streamable, we can't measure TTFT, so strictly speaking it's not "met"
107-
# OR we treat non-streamable as failing the streaming SLO.
108-
# Standard practice: if we can't measure it, it counts as failed or ignored.
109-
# Here assuming failed if data is missing but SLO required.
110-
ttft_met = False
106+
ttft_met = True # If TTFT SLO is set but we don't have a TTFT value (non-streamable), we can choose to consider it as met or not. Here we consider it met to avoid penalizing non-streamable requests.
111107
ttft_results.append(ttft_met)
112108

113109
# Check TPOT SLO (Only if streamable / tpot exists)
@@ -116,7 +112,7 @@ def calculate_slo_metrics(
116112
if tpot is not None:
117113
tpot_met = (tpot <= m.tpot_slo_sec)
118114
else:
119-
tpot_met = False
115+
tpot_met = True # Similar logic as TTFT for non-streamable requests
120116
tpot_results.append(tpot_met)
121117

122118
# Goodput Calculation Logic

0 commit comments

Comments
 (0)