perf: Only call .Available() once which prevents duplicate allocs (#2241)

DerekFrank · web-flow · commit 1515681cec49 · 2025-05-21T17:10:35.000-07:00
diff --git a/pkg/controllers/provisioning/scheduling/existingnode.go b/pkg/controllers/provisioning/scheduling/existingnode.go
@@ -50,12 +50,13 @@ func NewExistingNode(n *state.StateNode, topology *Topology, taints []v1.Taint,
 			daemonResources[k] = v
 		}
 	}
+	available := n.Available()
 	node := &ExistingNode{
 		StateNode:          n,
-		cachedAvailable:    n.Available(),
+		cachedAvailable:    available,
 		cachedTaints:       taints,
 		topology:           topology,
-		remainingResources: resources.Subtract(n.Available(), daemonResources),
+		remainingResources: resources.Subtract(available, daemonResources),
 		requirements:       scheduling.NewLabelRequirements(n.Labels()),
 	}
 	node.requirements.Add(scheduling.NewRequirement(v1.LabelHostname, v1.NodeSelectorOpIn, n.HostName()))

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,13 @@ func NewExistingNode(n state.StateNode, topology Topology, taints []v1.Taint,`
`50`	`50`	`daemonResources[k] = v`
`51`	`51`	`}`
`52`	`52`	`}`
	`53`	`+ available := n.Available()`
`53`	`54`	`node := &ExistingNode{`
`54`	`55`	`StateNode: n,`
`55`		`- cachedAvailable: n.Available(),`
	`56`	`+ cachedAvailable: available,`
`56`	`57`	`cachedTaints: taints,`
`57`	`58`	`topology: topology,`
`58`		`- remainingResources: resources.Subtract(n.Available(), daemonResources),`
	`59`	`+ remainingResources: resources.Subtract(available, daemonResources),`
`59`	`60`	`requirements: scheduling.NewLabelRequirements(n.Labels()),`
`60`	`61`	`}`
`61`	`62`	`node.requirements.Add(scheduling.NewRequirement(v1.LabelHostname, v1.NodeSelectorOpIn, n.HostName()))`