test: allow kwok provider deletion to terminate instance (#1996)

maxcao13 · web-flow · commit 9fe41b81d6db · 2025-02-14T23:22:20.000-08:00
Signed-off-by: Max Cao &lt;macao@redhat.com&gt;
diff --git a/kwok/cloudprovider/cloudprovider.go b/kwok/cloudprovider/cloudprovider.go
@@ -70,7 +70,7 @@ func (c CloudProvider) Delete(ctx context.Context, nodeClaim *v1.NodeClaim) erro
 		}
 		return fmt.Errorf("deleting node, %w", err)
 	}
-	return nil
+	return cloudprovider.NewNodeClaimNotFoundError(fmt.Errorf("instance terminated"))
 }
 
 func (c CloudProvider) Get(ctx context.Context, providerID string) (*v1.NodeClaim, error) {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func (c CloudProvider) Delete(ctx context.Context, nodeClaim *v1.NodeClaim) erro`
`70`	`70`	`}`
`71`	`71`	`return fmt.Errorf("deleting node, %w", err)`
`72`	`72`	`}`
`73`		`- return nil`
	`73`	`+ return cloudprovider.NewNodeClaimNotFoundError(fmt.Errorf("instance terminated"))`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`func (c CloudProvider) Get(ctx context.Context, providerID string) (*v1.NodeClaim, error) {`