Skip to content

Commit ee215df

Browse files
committed
remove instanceTypeLabels add; remove explicit capacity/zone; add all requirements
1 parent ecc0b73 commit ee215df

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

kwok/cloudprovider/cloudprovider.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,6 @@ func addInstanceLabels(labels map[string]string, instanceType *cloudprovider.Ins
222222
// Randomly add each new node to one of the pre-created kwokPartitions.
223223

224224
ret[v1alpha1.KwokPartitionLabelKey] = lo.Sample(kwokPartitions)
225-
ret[v1.CapacityTypeLabelKey] = offering.Requirements.Get(v1.CapacityTypeLabelKey).Any()
226-
ret[corev1.LabelTopologyZone] = offering.Requirements.Get(corev1.LabelTopologyZone).Any()
227225
ret[corev1.LabelHostname] = nodeClaim.Name
228226

229227
ret[v1alpha1.KwokLabelKey] = v1alpha1.KwokLabelValue

kwok/cloudprovider/helpers.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,6 @@ func setDefaultOptions(opts InstanceTypeOptions) InstanceTypeOptions {
139139
v1alpha1.InstanceCPULabelKey: cpu,
140140
v1alpha1.InstanceMemoryLabelKey: memory,
141141
}
142-
for _, offering := range opts.Offerings {
143-
for _, req := range offering.Requirements {
144-
if _, exists := opts.instanceTypeLabels[req.Key]; !exists {
145-
opts.instanceTypeLabels[req.Key] = req.Values[0]
146-
}
147-
}
148-
}
149142

150143
// if the user specified a different pod limit, override the default
151144
opts.Resources = lo.Assign(corev1.ResourceList{
@@ -180,6 +173,9 @@ func newInstanceType(options InstanceTypeOptions) *cloudprovider.InstanceType {
180173
for _, requirement := range offering.Requirements {
181174
v1.WellKnownLabels = v1.WellKnownLabels.Insert(requirement.Key)
182175
}
176+
for _, requirement := range offering.Offering.Requirements {
177+
v1.WellKnownLabels = v1.WellKnownLabels.Insert(requirement.Key)
178+
}
183179
}
184180

185181
requirements := scheduling.NewRequirements(

0 commit comments

Comments
 (0)