fix(nodeclaim): sleep for each reconciliation of consolidation controller

Signed-off-by: flavono123 <[email protected]>

Author: flavono123

pkg/controllers/nodeclaim/disruption/consolidation.go

@@ -18,7 +18,6 @@ package disruption
 
 import (
 	"context"
-	"time"
 
 	"github.com/samber/lo"
 	"k8s.io/utils/clock"
@@ -73,10 +72,6 @@ func (c *Consolidation) Reconcile(ctx context.Context, nodePool *v1.NodePool, no
 	// 3. Otherwise, add the consolidatable status condition if not already set
 	if !hasConsolidatableCondition {
 		nodeClaim.StatusConditions().SetTrue(v1.ConditionTypeConsolidatable)
-		// We sleep here after a set operation since we want to ensure that we are able to read our own writes
-		// so that we avoid duplicating log lines due to quick re-queues from our node watcher
-		time.Sleep(100 * time.Millisecond)
-
 		log.FromContext(ctx).V(1).Info("marking consolidatable")
 	}
 	return reconcile.Result{}, nil

pkg/controllers/nodeclaim/disruption/controller.go

@@ -18,6 +18,7 @@ package disruption
 
 import (
 	"context"
+	"time"
 
 	"go.uber.org/multierr"
 	corev1 "k8s.io/api/core/v1"
@@ -110,6 +111,10 @@ func (c *Controller) Reconcile(ctx context.Context, nodeClaim *v1.NodeClaim) (re
 			}
 			return reconcile.Result{}, client.IgnoreNotFound(err)
 		}
+		// We sleep here after a patch operation since we want to ensure that we are able to read our own writes
+		// so that we avoid duplicating metrics and log lines due to quick re-queues from our node watcher
+		// USE CAUTION when determining whether to increase this timeout or remove this line
+		time.Sleep(time.Second)
 	}
 	if errs != nil {
 		return reconcile.Result{}, errs