Helm chart installation fails with version 1.12

[Boris-Jancic]

Description

Observed Behavior:
Karpenter fails to run using default Helm values.
I noticed that NodeOverlay & StaticCapacity are empty & dont have their booleans in the FEATURE_GATES env variable of the karpenter deployment

panic: parsing feature gates, invalid value of NodeOverlay , err: strconv.ParseBool: parsing "": invalid syntax 

panic: parsing feature gates, invalid value of StaticCapacity: , err: strconv.ParseBool: parsing "": invalid syntax 

Fix:
I fixed this by adding in the booleans by running kubectl edit deployment/karpenter KARPENTER_NAMESPACE & adding the values manually.
Before edit

- name: FEATURE_GATES                                                                                                                                                
value: ReservedCapacity=true,SpotToSpotConsolidation=false,NodeRepair=false,NodeOverlay=,StaticCapacity=

After edit

- name: FEATURE_GATES                                                                                                                                                
value: ReservedCapacity=true,SpotToSpotConsolidation=false,NodeRepair=false,NodeOverlay=false,StaticCapacity=false

Expected Behavior:
Karpenter runs with default Helm values.

Reproduction Steps (Please include YAML):
Upgrading from 1.7 to 1.12 using the bellow values.yml

USER-SUPPLIED VALUES:
controller:
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1
      memory: 1Gi
serviceAccount:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::ACC_NUM:role/KARPENTER_ROLE_NAME
settings:
  clusterName: CLUSTER_NAME
  enableZonalShift: true
  interruptionQueue: CLUSTER_NAME
tolerations:
- effect: NoSchedule
  key: CriticalAddonsOnly
  operator: Exists

Versions:

• Chart Version: 1.7
• Kubernetes Version (kubectl version):

▶ k version
Client Version: v1.36.1
Kustomize Version: v5.8.1
Server Version: v1.35.4-eks-40737a8

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[jmdeal]

/triage needs-investigation