Remove dead code and test for Realpath. (#895)

Related issue: 894

while investigating test coverage for changes to installed symlinks this was found to be unused

Author: asakatida

internal/environment/environment.go

@@ -109,22 +109,3 @@ func (p Paths) PluginInstallReceiptPath(plugin string) string {
 func (p Paths) PluginVersionInstallPath(plugin, version string) string {
 	return filepath.Join(p.InstallPath(), plugin, version)
 }
-
-// Realpath evaluates symbolic links. If the path is not a symbolic link, it
-// returns the cleaned path. Symbolic links with relative paths return error.
-func Realpath(path string) (string, error) {
-	s, err := os.Lstat(path)
-	if err != nil {
-		return "", errors.Wrapf(err, "failed to stat the currently executed path (%q)", path)
-	}
-
-	if s.Mode()&os.ModeSymlink != 0 {
-		if path, err = os.Readlink(path); err != nil {
-			return "", errors.Wrap(err, "failed to resolve the symlink of the currently executed version")
-		}
-		if !filepath.IsAbs(path) {
-			return "", errors.Errorf("symbolic link is relative (%s)", path)
-		}
-	}
-	return filepath.Clean(path), nil
-}

internal/environment/environment_test.go

@@ -15,14 +15,12 @@
 package environment
 
 import (
-	"os"
 	"path/filepath"
 	"strings"
 	"testing"
 
 	"k8s.io/client-go/util/homedir"
 
-	"sigs.k8s.io/krew/internal/testutil"
 	"sigs.k8s.io/krew/pkg/constants"
 )
 
@@ -78,48 +76,3 @@ func TestPaths(t *testing.T) {
 		t.Errorf("PluginInstallReceiptPath()=%s; expected suffix 'receipts/my-plugin.yaml'", got)
 	}
 }
-
-func TestRealpath(t *testing.T) {
-	tmpDir := testutil.NewTempDir(t)
-
-	// create regular file
-	tmpDir.Write("regular-file", nil)
-
-	// create absolute symlink
-	orig := filepath.Clean(os.TempDir())
-	if err := os.Symlink(orig, filepath.Join(tmpDir.Root(), "symbolic-link-abs")); err != nil {
-		t.Fatal(err)
-	}
-
-	// create relative symlink
-	if err := os.Symlink("./another-file", filepath.Join(tmpDir.Root(), "symbolic-link-rel")); err != nil {
-		t.Fatal(err)
-	}
-
-	tests := []struct {
-		name    string
-		in      string
-		want    string
-		wantErr bool
-	}{
-		{"file not exists", tmpDir.Path("/not/exists"), "", true},
-		{"directory", tmpDir.Root(), tmpDir.Root(), false},
-		{"regular file", tmpDir.Path("regular-file"), tmpDir.Path("regular-file"), false},
-		{"directory unclean", tmpDir.Path("foo/.."), tmpDir.Root(), false},
-		{"regular file unclean", tmpDir.Path("regular-file/foo/.."), tmpDir.Path("regular-file"), false},
-		{"relative symbolic link", tmpDir.Path("symbolic-link-rel"), "", true},
-		{"absolute symbolic link", tmpDir.Path("symbolic-link-abs"), orig, false},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			got, err := Realpath(tt.in)
-			if (err != nil) != tt.wantErr {
-				t.Errorf("Realpath(%s) error = %v, wantErr %v", tt.in, err, tt.wantErr)
-				return
-			}
-			if got != tt.want {
-				t.Errorf("Realpath(%s) = %v, want %v", tt.in, got, tt.want)
-			}
-		})
-	}
-}