generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 274
Open
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.needs-kreptriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
Feature Description
Problem Statement:
Current Behaviour supports only reference the "schema" variable.
I would like to be able to use externalRef in includeWhen statement. Here is example how it can look like:
`apiVersion: kro.run/v1alpha1
kind: ResourceGraphDefinition
metadata:
name: foo
spec:
schema:
apiVersion: v1
kind: Foo
spec:
crdName: string | required=true description="Name of the CRD"
resources:
- id: serviceAccount
externalRef:
apiVersion: v1
kind: ServiceAccount
metadata:
name: service-account-name
namespace: ${schema.spec.namespace}
- id: storageBucket
template:
apiVersion: storage.cnrm.cloud.google.com/v1beta1
kind: StorageBucket
metadata:
name: ${schema.metadata.name}-bucket
namespace: ${schema.metadata.namespace}
includeWhen:
- ${serviceAccount.metadata.exists(x, x.name == 'test')}`
Proposed Solution:
Users can use externalRef resource in includeWhen cel expression to reference to externalRef resource
Alternatives Considered:
Additional Context:
It used to be possible to use externalRef in includeWhen statement before this PR where behaviour was changed.
- Please vote on this issue by adding a 👍 reaction to the original issue
- If you are interested in working on this feature, please leave a comment
a-buck, jakobmoellerdev, tjamet and bschaatsbergen
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.needs-kreptriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.