Skip to content

Commit 86162fa

Browse files
committed
centralize remove node defaults
1 parent 6b8911c commit 86162fa

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

roles/remove-node/post-remove/tasks/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
- name: Remove-node | Delete node
3-
command: "{{ kubectl }} delete node {{ kube_override_hostname | default(inventory_hostname) }}"
3+
command: "{{ kubectl }} delete node {{ kube_override_hostname }}"
44
delegate_to: "{{ groups['kube_control_plane'] | first }}"
55
when:
66
- groups['kube_control_plane'] | length > 0
77
# ignore servers that are not nodes
8-
- ('k8s_cluster' in group_names) and kube_override_hostname | default(inventory_hostname) in nodes.stdout_lines
8+
- ('k8s_cluster' in group_names) and kube_override_hostname in nodes.stdout_lines
99
retries: "{{ delete_node_retries }}"
1010
# Sometimes the api-server can have a short window of indisponibility when we delete a control plane node
1111
delay: "{{ delete_node_delay_seconds }}"

roles/remove_node/pre_remove/tasks/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
--ignore-daemonsets
1717
--grace-period {{ drain_grace_period }}
1818
--timeout {{ drain_timeout }}
19-
--delete-emptydir-data {{ kube_override_hostname | default(inventory_hostname) }}
19+
--delete-emptydir-data {{ kube_override_hostname }}
2020
when:
2121
- groups['kube_control_plane'] | length > 0
2222
# ignore servers that are not nodes
23-
- kube_override_hostname | default(inventory_hostname) in nodes.stdout_lines
23+
- kube_override_hostname in nodes.stdout_lines
2424
register: result
2525
failed_when: result.rc != 0 and not allow_ungraceful_removal
2626
delegate_to: "{{ groups['kube_control_plane'] | first }}"
@@ -34,10 +34,10 @@
3434
register: nodes_with_volumes
3535
delegate_to: "{{ groups['kube_control_plane'] | first }}"
3636
changed_when: false
37-
until: not (kube_override_hostname | default(inventory_hostname) in nodes_with_volumes.stdout_lines)
37+
until: not (kube_override_hostname in nodes_with_volumes.stdout_lines)
3838
retries: 3
3939
delay: "{{ drain_grace_period }}"
4040
when:
4141
- groups['kube_control_plane'] | length > 0
4242
- not allow_ungraceful_removal
43-
- kube_override_hostname | default(inventory_hostname) in nodes.stdout_lines
43+
- kube_override_hostname in nodes.stdout_lines

0 commit comments

Comments
 (0)