fix: parameter passing error (#6715)

Panlq · web-flow · commit 06cb5118a7a1 · 2025-09-03T08:01:16.000-07:00
diff --git a/pkg/controller/jobs/deployment/deployment_webhook.go b/pkg/controller/jobs/deployment/deployment_webhook.go
@@ -131,7 +131,7 @@ func (wh *Webhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Ob
 	// or if the queue-name has been deleted.
 	isSuspended := oldDeployment.Status.ReadyReplicas == 0
 	if !isSuspended || newQueueName == "" {
-		allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldQueueName, newQueueName, queueNameLabelPath)...)
+		allErrs = append(allErrs, apivalidation.ValidateImmutableField(newQueueName, oldQueueName, queueNameLabelPath)...)
 	}
 	if !isSuspended || jobframework.IsWorkloadPriorityClassNameEmpty(newDeployment.Object()) {
 		allErrs = append(allErrs, jobframework.ValidateUpdateForWorkloadPriorityClassName(oldDeployment.Object(), newDeployment.Object())...)
diff --git a/pkg/controller/jobs/statefulset/statefulset_webhook.go b/pkg/controller/jobs/statefulset/statefulset_webhook.go
@@ -142,7 +142,7 @@ func (wh *Webhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Ob
 	// or if the queue-name has been deleted.
 	isSuspended := oldStatefulSet.Status.ReadyReplicas == 0
 	if !isSuspended || newQueueName == "" {
-		allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldQueueName, newQueueName, queueNameLabelPath)...)
+		allErrs = append(allErrs, apivalidation.ValidateImmutableField(newQueueName, oldQueueName, queueNameLabelPath)...)
 	}
 	if !isSuspended || jobframework.IsWorkloadPriorityClassNameEmpty(newStatefulSet.Object()) {
 		allErrs = append(allErrs, jobframework.ValidateUpdateForWorkloadPriorityClassName(

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ func (wh *Webhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Ob`
`131`	`131`	`// or if the queue-name has been deleted.`
`132`	`132`	`isSuspended := oldDeployment.Status.ReadyReplicas == 0`
`133`	`133`	`if !isSuspended \|\| newQueueName == "" {`
`134`		`- allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldQueueName, newQueueName, queueNameLabelPath)...)`
	`134`	`+ allErrs = append(allErrs, apivalidation.ValidateImmutableField(newQueueName, oldQueueName, queueNameLabelPath)...)`
`135`	`135`	`}`
`136`	`136`	`if !isSuspended \|\| jobframework.IsWorkloadPriorityClassNameEmpty(newDeployment.Object()) {`
`137`	`137`	`allErrs = append(allErrs, jobframework.ValidateUpdateForWorkloadPriorityClassName(oldDeployment.Object(), newDeployment.Object())...)`
Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func (wh *Webhook) ValidateUpdate(ctx context.Context, oldObj, newObj runtime.Ob`
`142`	`142`	`// or if the queue-name has been deleted.`
`143`	`143`	`isSuspended := oldStatefulSet.Status.ReadyReplicas == 0`
`144`	`144`	`if !isSuspended \|\| newQueueName == "" {`
`145`		`- allErrs = append(allErrs, apivalidation.ValidateImmutableField(oldQueueName, newQueueName, queueNameLabelPath)...)`
	`145`	`+ allErrs = append(allErrs, apivalidation.ValidateImmutableField(newQueueName, oldQueueName, queueNameLabelPath)...)`
`146`	`146`	`}`
`147`	`147`	`if !isSuspended \|\| jobframework.IsWorkloadPriorityClassNameEmpty(newStatefulSet.Object()) {`
`148`	`148`	`allErrs = append(allErrs, jobframework.ValidateUpdateForWorkloadPriorityClassName(`