Fix race in RemoveRemoteObjects where remote LWS is not deleted (#9201)

When MultiKueueGC deletes the remote workload before the reconciler
processes the deletion, RemoveRemoteObjects would early-return on
remWl == nil without deleting the remote controller object (e.g., LWS).

Move DeleteRemoteObject before the nil check to ensure the remote
controller object is always deleted regardless of remote workload state.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>

Author: sohankunkerkar

pkg/controller/admissionchecks/multikueue/workload.go

@@ -127,14 +127,18 @@ func (g *wlGroup) bestMatchByCondition(conditionType string) (*metav1.Condition,
 	return bestMatchCond, bestMatchRemote
 }
 
+// RemoveRemoteObjects deletes the remote controller object and workload for a cluster.
+// The controller object is deleted first to handle cases where GC has already removed
+// the remote workload.
 func (g *wlGroup) RemoveRemoteObjects(ctx context.Context, cluster string) error {
+	if err := g.jobAdapter.DeleteRemoteObject(ctx, g.remoteClients[cluster].client, g.controllerKey); err != nil {
+		return fmt.Errorf("deleting remote controller object: %w", err)
+	}
+
 	remWl := g.remotes[cluster]
 	if remWl == nil {
 		return nil
 	}
-	if err := g.jobAdapter.DeleteRemoteObject(ctx, g.remoteClients[cluster].client, g.controllerKey); err != nil {
-		return fmt.Errorf("deleting remote controller object: %w", err)
-	}
 
 	if controllerutil.RemoveFinalizer(remWl, kueue.ResourceInUseFinalizerName) {
 		if err := g.remoteClients[cluster].client.Update(ctx, remWl); err != nil {