CLI: Deprecate short name wl from workload crd

Author: kannon92

apis/kueue/v1beta1/workload_types.go

@@ -783,7 +783,7 @@ const (
 // +kubebuilder:printcolumn:name="Admitted",JSONPath=".status.conditions[?(@.type=='Admitted')].status",type="string",description="Admission status"
 // +kubebuilder:printcolumn:name="Finished",JSONPath=".status.conditions[?(@.type=='Finished')].status",type="string",description="Workload finished"
 // +kubebuilder:printcolumn:name="Age",JSONPath=".metadata.creationTimestamp",type="date",description="Time this workload was created"
-// +kubebuilder:resource:shortName={wl,kwl,kueueworkload}
+// +kubebuilder:resource:shortName={kwl,kueueworkload}
 
 // Workload is the Schema for the workloads API
 // +kubebuilder:validation:XValidation:rule="has(self.status) && has(self.status.conditions) && self.status.conditions.exists(c, c.type == 'QuotaReserved' && c.status == 'True') && has(self.status.admission) ? size(self.spec.podSets) == size(self.status.admission.podSetAssignments) : true", message="podSetAssignments must have the same number of podSets as the spec"

apis/kueue/v1beta2/workload_types.go

@@ -1003,7 +1003,7 @@ const (
 // +kubebuilder:printcolumn:name="Admitted",JSONPath=".status.conditions[?(@.type=='Admitted')].status",type="string",description="Admission status"
 // +kubebuilder:printcolumn:name="Finished",JSONPath=".status.conditions[?(@.type=='Finished')].status",type="string",description="Workload finished"
 // +kubebuilder:printcolumn:name="Age",JSONPath=".metadata.creationTimestamp",type="date",description="Time this workload was created"
-// +kubebuilder:resource:shortName={wl,kwl,kueueworkload}
+// +kubebuilder:resource:shortName={kwl,kueueworkload}
 
 // Workload is the Schema for the workloads API
 // +kubebuilder:validation:XValidation:rule="has(self.status) && has(self.status.conditions) && self.status.conditions.exists(c, c.type == 'QuotaReserved' && c.status == 'True') && has(self.status.admission) ? size(self.spec.podSets) == size(self.status.admission.podSetAssignments) : true", message="podSetAssignments must have the same number of podSets as the spec"

charts/kueue/templates/crd/kueue.x-k8s.io_workloads.yaml

@@ -44,7 +44,6 @@ spec:
     listKind: WorkloadList
     plural: workloads
     shortNames:
-      - wl
       - kwl
       - kueueworkload
     singular: workload

cmd/kueuectl/app/delete/delete_workload.go

@@ -89,7 +89,7 @@ func NewWorkloadCmd(clientGetter clientgetter.ClientGetter, streams genericioopt
 	cmd := &cobra.Command{
 		Use:                   "workload NAME [--yes] [--all] [--dry-run STRATEGY]",
 		DisableFlagsInUseLine: true,
-		Aliases:               []string{"wl", "kwl", "kueueworkload"},
+		Aliases:               []string{"kwl", "kueueworkload"},
 		Short:                 "Delete the given Workload and its corresponding Job",
 		Long:                  wlLong,
 		Example:               wlExample,

cmd/kueuectl/app/list/list_test.go

@@ -131,7 +131,7 @@ ns2         wl2               j2         lq2          cq2            PENDING
 `,
 		},
 		"should print workload list with all namespaces (short command and flag)": {
-			args: []string{"wl", "-A"},
+			args: []string{"kwl", "-A"},
 			objs: []runtime.Object{
 				utiltestingapi.MakeWorkload("wl1", "ns1").
 					OwnerReference(batchv1.SchemeGroupVersion.WithKind("Job"), "j1", "test-uid").

cmd/kueuectl/app/list/list_workload.go

@@ -100,7 +100,7 @@ func NewWorkloadCmd(clientGetter clientgetter.ClientGetter, streams genericioopt
 		Use: "workload [--clusterqueue CLUSTER_QUEUE_NAME] [--localqueue LOCAL_QUEUE_NAME] [--status STATUS] [--selector key1=value1] [--field-selector key1=value1] [--all-namespaces] [--for TYPE[.API-GROUP]/NAME]",
 		// To do not add "[flags]" suffix on the end of usage line
 		DisableFlagsInUseLine: true,
-		Aliases:               []string{"wl", "kwl", "kueueworkload"},
+		Aliases:               []string{"kwl", "kueueworkload"},
 		Short:                 "List Workload",
 		Long:                  wlLong,
 		Example:               wlExample,

cmd/kueuectl/app/passthrough/passthrough.go

@@ -49,7 +49,7 @@ var (
 	}
 
 	passThroughTypes = []passThroughType{
-		{name: "workload", aliases: []string{"wl", "kwl", "kueueworkload"}},
+		{name: "workload", aliases: []string{"kwl", "kueueworkload"}},
 		{name: "clusterqueue", aliases: []string{"cq"}},
 		{name: "localqueue", aliases: []string{"lq"}},
 		{name: "resourceflavor", aliases: []string{"rf"}},

cmd/kueuectl/app/resume/resume_workload.go

@@ -42,7 +42,7 @@ func NewWorkloadCmd(clientGetter clientgetter.ClientGetter, streams genericioopt
 		Use: "workload NAME [--namespace NAMESPACE] [--dry-run STRATEGY]",
 		// To do not add "[flags]" suffix on the end of usage line
 		DisableFlagsInUseLine: true,
-		Aliases:               []string{"wl", "kwl", "kueueworkload"},
+		Aliases:               []string{"kwl", "kueueworkload"},
 		Short:                 "Resume the Workload",
 		Long:                  wlLong,
 		Example:               wlExample,

cmd/kueuectl/app/stop/stop_workload.go

@@ -46,7 +46,7 @@ func NewWorkloadCmd(clientGetter clientgetter.ClientGetter, streams genericioopt
 		Use: "workload NAME [--namespace NAMESPACE] [--dry-run STRATEGY]",
 		// To do not add "[flags]" suffix on the end of usage line
 		DisableFlagsInUseLine: true,
-		Aliases:               []string{"wl", "kueueworkload", "kwl"},
+		Aliases:               []string{"kueueworkload", "kwl"},
 		Short:                 "Stop the Workload",
 		Long:                  wlLong,
 		Example:               wlExample,

config/components/crd/bases/kueue.x-k8s.io_workloads.yaml

@@ -12,7 +12,6 @@ spec:
     listKind: WorkloadList
     plural: workloads
     shortNames:
-    - wl
     - kwl
     - kueueworkload
     singular: workload