Added makezero linter. (#2653)

Author: mbobrovskyi

.golangci.yaml

@@ -43,6 +43,7 @@ linters:
     - perfsprint
     - revive
     - unconvert
+    - makezero
 
 # Settings related to issues
 issues:

pkg/controller/jobframework/setup_test.go

@@ -119,10 +119,9 @@ func TestSetupControllers(t *testing.T) {
 					return k8sClient, nil
 				},
 				MapperProvider: func(*rest.Config, *http.Client) (apimeta.RESTMapper, error) {
-					gvs := make([]schema.GroupVersion, len(tc.mapperGVKs))
-					for _, gvk := range tc.mapperGVKs {
-						gvs = append(gvs, gvk.GroupVersion())
-					}
+					gvs := slices.Map(tc.mapperGVKs, func(gvk *schema.GroupVersionKind) schema.GroupVersion {
+						return gvk.GroupVersion()
+					})
 					mapper := apimeta.NewDefaultRESTMapper(gvs)
 					for _, gvk := range tc.mapperGVKs {
 						mapper.Add(gvk, apimeta.RESTScopeNamespace)

pkg/webhooks/workload_webhook.go

@@ -249,7 +249,7 @@ func validateReclaimablePods(obj *kueue.Workload, basePath *field.Path) field.Er
 	for i := range obj.Spec.PodSets {
 		name := obj.Spec.PodSets[i].Name
 		knowPodSets[name] = &obj.Spec.PodSets[i]
-		knowPodSetNames = append(knowPodSetNames, name)
+		knowPodSetNames[i] = name
 	}
 
 	var ret field.ErrorList