Make topology levels immutable. (#3641)

mbobrovskyi · web-flow · commit f486009179da · 2024-11-26T08:04:56.000Z
diff --git a/apis/kueue/v1alpha1/tas_types.go b/apis/kueue/v1alpha1/tas_types.go
@@ -69,6 +69,7 @@ type TopologySpec struct {
 	// +listType=atomic
 	// +kubebuilder:validation:MinItems=1
 	// +kubebuilder:validation:MaxItems=8
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="the levels field is immutable"
 	Levels []TopologyLevel `json:"levels,omitempty"`
 }
 
diff --git a/charts/kueue/templates/crd/kueue.x-k8s.io_topologies.yaml b/charts/kueue/templates/crd/kueue.x-k8s.io_topologies.yaml
@@ -78,6 +78,9 @@ spec:
                 minItems: 1
                 type: array
                 x-kubernetes-list-type: atomic
+                x-kubernetes-validations:
+                - message: the levels field is immutable
+                  rule: self == oldSelf
             required:
             - levels
             type: object
diff --git a/config/components/crd/bases/kueue.x-k8s.io_topologies.yaml b/config/components/crd/bases/kueue.x-k8s.io_topologies.yaml
@@ -63,6 +63,9 @@ spec:
                 minItems: 1
                 type: array
                 x-kubernetes-list-type: atomic
+                x-kubernetes-validations:
+                - message: the levels field is immutable
+                  rule: self == oldSelf
             required:
             - levels
             type: object

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@ type TopologySpec struct {`
`69`	`69`	`// +listType=atomic`
`70`	`70`	`// +kubebuilder:validation:MinItems=1`
`71`	`71`	`// +kubebuilder:validation:MaxItems=8`
	`72`	`+ // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="the levels field is immutable"`
`72`	`73`	Levels []TopologyLevel `json:"levels,omitempty"`
`73`	`74`	`}`
`74`	`75`