adding fix for the issue #4067- Add disabled waitForPodsReady to configuration by default

[OMNARAYANYU]

What type of PR is this?

• This is a code change to add waitForPodsReady to configuration by default, which is currently commented out. It shouldn't have any impact though as it's disabled by default. It is required to increase consistency in defaults.go file.

What this PR does / why we need it:

• It fixes the github Issue Add disabled waitForPodsReady to configuration by default. #4067

Which issue(s) this PR fixes:

Fixes #4067

Special notes for your reviewer:

• This is my first contribution. I have followed the Kubernettes playground before raising the request.

Does this PR introduce a user-facing change?

None, there is no user facing change associated with the fix

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OMNARAYANYU
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @OMNARAYANYU!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @OMNARAYANYU. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	3002ad9
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67bbcc7f6faf310008939b1a

[gabesaba]

/ok-to-test

[gabesaba]

Thanks for the PR!

Please update issue title and the release note ("Does this PR introduce a user-facing change?") with the change.

[OMNARAYANYU]

Thanks for the PR!

Please update issue title and the release note ("Does this PR introduce a user-facing change?") with the change.

I have made the suggested changes, please review when you have a chance.

[tenzen-y]

Thank you for proceeding with this PR.

This contains default behavior change as I mentioned #4067 (comment).
So, before we move forward here, let me confirm @PBundyra if this default behavior change is intended.

The defaulter does not specify timeout if waitForPodsReady is not specified.

/hold

[mimowo]

/assign @PBundyra
Based on the question #4265 (comment)

[PBundyra]

Hi @OMNARAYANYU, please see my comment under the original issue #4067 (comment) This requires slightly different changes than ones you made. I'm happy to review them once they're done

To sum up, we don't want to uncomment the fields, but rather make changes in the apis/config/v1beta1/defaults.go file to make it consistent