-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAS: allow to dump the usage of domains for TAS ResourceFlavors #4295
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vladikkuzn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @mimowo |
07d2aec
to
95d34c0
Compare
/test all |
/ok-to-test |
/test pull-kueue-verify-main |
log.Info("TAS Snapshot Free Capacity", | ||
"clusterQueue", cqName, | ||
"resourceFlavor", tasFlavor, | ||
"freeCapacityPerDomain", tasSnapshot.FreeCapacityPerDomain(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify that this log line works properly when running integration test, and that is not affected by #4137. There is no need to write a new integration test, unless this path is not covered. We only want to make sure that this line is output properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks now: 2025/02/26 10:38:20 INFO TAS Snapshot Free Capacity freeCapacityPerDomain="map[domain1:map[cpu:2000 memory:4294967296 nvidia.com/gpu:1] domain2:map[cpu:1000 memory:2147483648]]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pretty print these? 4294967296, 2147483648 is hard for humans to read
Try this function
kueue/pkg/resources/requests.go
Lines 101 to 104 in f8015cb
func ResourceQuantityString(name corev1.ResourceName, v int64) string { | |
rq := ResourceQuantity(name, v) | |
return rq.String() | |
} |
95d34c0
to
6da5f7c
Compare
* Add test * Preserve resources
6da5f7c
to
0ddfb24
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows to dump the free capacity of TAS snapshots per domain.
Which issue(s) this PR fixes:
Fixes #3493
Special notes for your reviewer:
Does this PR introduce a user-facing change?