generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAS: allow to dump the usage of domains for TAS ResourceFlavors #4295
Open
vladikkuzn
wants to merge
2
commits into
kubernetes-sigs:main
Choose a base branch
from
epam:dump-the-usage-of-domains
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
Copyright The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package cache | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/google/go-cmp/cmp" | ||
corev1 "k8s.io/api/core/v1" | ||
|
||
"sigs.k8s.io/kueue/pkg/resources" | ||
) | ||
|
||
func TestFreeCapacityPerDomain(t *testing.T) { | ||
snapshot := &TASFlavorSnapshot{ | ||
leaves: leafDomainByID{ | ||
"domain1": &leafDomain{ | ||
freeCapacity: resources.Requests{ | ||
corev1.ResourceCPU: 2000, | ||
corev1.ResourceMemory: 4 * 1024 * 1024 * 1024, // 4 GiB | ||
"nvidia.com/gpu": 1, | ||
}, | ||
}, | ||
"domain2": &leafDomain{ | ||
freeCapacity: resources.Requests{ | ||
corev1.ResourceCPU: 1000, | ||
corev1.ResourceMemory: 2 * 1024 * 1024 * 1024, // 2 GiB | ||
}, | ||
}, | ||
}, | ||
} | ||
|
||
expected := map[string]resources.Requests{ | ||
"domain1": { | ||
corev1.ResourceCPU: 2000, | ||
corev1.ResourceMemory: 4 * 1024 * 1024 * 1024, | ||
"nvidia.com/gpu": 1, | ||
}, | ||
"domain2": { | ||
corev1.ResourceCPU: 1000, | ||
corev1.ResourceMemory: 2 * 1024 * 1024 * 1024, | ||
}, | ||
} | ||
|
||
actual := snapshot.FreeCapacityPerDomain() | ||
if diff := cmp.Diff(expected, actual); diff != "" { | ||
t.Errorf("FreeCapacityPerDomain() mismatch (-expected +actual):\n%s", diff) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify that this log line works properly when running integration test, and that is not affected by #4137. There is no need to write a new integration test, unless this path is not covered. We only want to make sure that this line is output properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks now:
2025/02/26 10:38:20 INFO TAS Snapshot Free Capacity freeCapacityPerDomain="map[domain1:map[cpu:2000 memory:4294967296 nvidia.com/gpu:1] domain2:map[cpu:1000 memory:2147483648]]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pretty print these? 4294967296, 2147483648 is hard for humans to read
Try this function
kueue/pkg/resources/requests.go
Lines 101 to 104 in f8015cb