Fork/uidlabel

[avrittrohwer]

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Makes it easy to kubectl describe the Workload that preempted another workload using the --selector CLI flag.

Which issue(s) this PR fixes:

Fixes #4038

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds a `kueue.x-k8s.io/workload-uid` label to Kueue Workload objects so they are easily retrieved by UID with `kubectl get workloads --selector=kueue.x-k8s.io/workload-uid=<UID>`

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: avrittrohwer
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @avrittrohwer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	670219c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67b7cf7e05ade40008c51a2d
😎 Deploy Preview	https://deploy-preview-4339--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mimowo]

/ok-to-test

[mimowo]

This probably needs to be relaxed to "field is immutable once set" since this is set in workload_reconciler.
The bonus question: could it be set on workload creation with Mutating Admission Policy ( I know it is still Alpha, but we could already plan to move the setting code).

[avrittrohwer]

Do you know how I could test out this validation rule? My current Reconcile unit test does not look like it exercises this rule

[mimowo]

Yeah, I don't think you can test it at the UT level, because it is enforced by api-server.

We cover other validation rules at the level of integration tests example

[mimowo]

I left some initial comment after brief scan, but leaving the first full pass to @gabesaba or @tenzen-y
/assign @gabesaba

[gabesaba]

Hi. I noticed this is still marked as Draft. Is it ready for a review?

[k8s-ci-robot]

@avrittrohwer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kueue-test-integration-main	670219c	link	true	/test pull-kueue-test-integration-main
pull-kueue-verify-main	670219c	link	true	/test pull-kueue-verify-main
pull-kueue-test-scheduling-perf-main	670219c	link	true	/test pull-kueue-test-scheduling-perf-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.