Skip to content

Add default tolerations to controller deployment #98

@ajaysundark

Description

@ajaysundark

The node-readiness-controller shouldn't be blocked by node taints creating a possible deadlock if the taints were not properly managed in the cluster. Also, currently the controller deployment targets control-plane nodes as default, for default-behavior 'any available node' works better.

  1. Remove nodeSelector for controller (manager) deployment in config/manager/manager.yaml
  2. Add broad tolerations for the deployment., ie:
spec:
  template:
    spec:
      tolerations:
      - operator: Exists
        effect: NoSchedule
      - operator: Exists
        effect: NoExecute

In the future this could be replaced with tolerate only readiness.k8s.io/* taints specifically, but that's need wildcard support in K8s.

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions