fix: added weighting to summation in order to consider a mix of partionable and non-partitionable devices

MenD32 · MenD32 · commit 2ed460241858 · 2025-11-21T20:36:13.000+02:00
Signed-off-by: MenD32 &lt;amit.mendelevitch@gmail.com&gt;
diff --git a/cluster-autoscaler/simulator/dynamicresources/utils/utilization.go b/cluster-autoscaler/simulator/dynamicresources/utils/utilization.go
@@ -129,7 +129,7 @@ func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlic
 	var partitionableDevicesUtilizationWeight float64 = uniquePartitionableDevicesCount / totalUniqueDevices
 	var nonPartitionableDevicesUtilizationWeight float64 = 1 - partitionableDevicesUtilizationWeight
 	// when a pool has both atomic and partitionable devices, we sum their utilizations since they are mutually exclusive
-	return partitionableUtilization * partitionableDevicesUtilizationWeight + atomicDevicesUtilization * nonPartitionableDevicesUtilizationWeight
+	return partitionableUtilization*partitionableDevicesUtilizationWeight + atomicDevicesUtilization*nonPartitionableDevicesUtilizationWeight
 }
 
 // calculateConsumedCounters calculates the total counters consumed by a list of devices

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func calculatePoolUtil(unallocated, allocated []resourceapi.Device, resourceSlic`
`129`	`129`	`var partitionableDevicesUtilizationWeight float64 = uniquePartitionableDevicesCount / totalUniqueDevices`
`130`	`130`	`var nonPartitionableDevicesUtilizationWeight float64 = 1 - partitionableDevicesUtilizationWeight`
`131`	`131`	`// when a pool has both atomic and partitionable devices, we sum their utilizations since they are mutually exclusive`
`132`		`- return partitionableUtilization * partitionableDevicesUtilizationWeight + atomicDevicesUtilization * nonPartitionableDevicesUtilizationWeight`
	`132`	`+ return partitionableUtilizationpartitionableDevicesUtilizationWeight + atomicDevicesUtilizationnonPartitionableDevicesUtilizationWeight`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`// calculateConsumedCounters calculates the total counters consumed by a list of devices`