Skip to content

Commit 8432460

Browse files
committed
Add notes for TLS secret
Signed-off-by: Omer Aplatony <[email protected]>
1 parent 404d09e commit 8432460

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

vertical-pod-autoscaler/charts/vertical-pod-autoscaler/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ admissionController:
5050
In this mode:
5151
- The VPA admission controller creates and manages the webhook itself
5252
- The application handles its own certificate generation
53+
Important: You are responsible for creating the TLS secret before or after installing the chart. The admission controller will only create the `MutatingWebhookConfiguration` once the secret exists.
54+
If the secret is created after the Helm install, you must restart the admission controller pod to trigger webhook registration.
5355

5456
## Migration Guides
5557

vertical-pod-autoscaler/charts/vertical-pod-autoscaler/README.md.gotmpl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ admissionController:
4747
In this mode:
4848
- The VPA admission controller creates and manages the webhook itself
4949
- The application handles its own certificate generation
50+
Important: You are responsible for creating the TLS secret before or after installing the chart. The admission controller will only create the `MutatingWebhookConfiguration` once the secret exists.
51+
If the secret is created after the Helm install, you must restart the admission controller pod to trigger webhook registration.
5052

5153
## Migration Guides
5254

vertical-pod-autoscaler/charts/vertical-pod-autoscaler/templates/NOTES.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,13 @@ Webhook Configuration:
1818
{{- if .Values.admissionController.registerWebhook }}
1919
Mode: Application-managed
2020
- Webhook registered by: admission-controller application
21-
- Certificates managed by: admission-controller application
21+
- Certificates managed by: User (you must provide the TLS secret)
22+
23+
⚠️ IMPORTANT: You must create the TLS secret '{{ include "vertical-pod-autoscaler.admissionController.tls.secretName" . }}'
24+
The admission controller will only register the webhook once this secret exists.
25+
If the secret is created after this install, restart the admission controller:
26+
27+
kubectl rollout restart deployment/{{ include "vertical-pod-autoscaler.admissionController.fullname" . }} -n {{ .Release.Namespace }}
2228
{{- else if .Values.admissionController.certGen.enabled }}
2329
Mode: Helm-managed (recommended)
2430
- Webhook registered by: Helm (MutatingWebhookConfiguration)

0 commit comments

Comments
 (0)