-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPA: Passing args to vpa-updater #7291
Comments
/area vertical-pod-autoscaler |
Can you describe what you except to happen? /label triage/needs-information |
@adrianmoisey: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label needs-information |
@adrianmoisey: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/triage needs-information |
Atleast I should see
vpa.yaml
|
This log happens before the logs that you've pasted. Is your log stream being truncated? You've provided very little detail here. Please provide details steps on how to reproduce this issue. |
I changed the default param to
Build the docker image and updated the deployment to take effect.
And the updater gives me the expected logs around what is happening:-
if I pass the args to the default image. I got no repetitive logs as shown above. The logs i ma getting are as shown in comment Here is how I am passing the arg.
I think arg is getting passed coz updater is not screaming about that it needs 2 (default) replicas. But why no other logs are coming ? Also, the same behaviour for admission-controller, so I think either i am expecting something wrong or I am making some mistake. Things are working fine for me BTW, as I can see request/limit updated for targetRef. Pls let me know if u need further details. |
Right, Ok. I see what you're saying. /assign |
/assign omerap12 |
@adrianmoisey: GitHub didn't allow me to assign the following users: omerap12. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
@omerap12 and I looked into this, and found the following:
It seems that the Dockerfile sets some defaults, and when an arg is passed to it from Kubernetes, those defaults are overridden. A workaround for now is to set those two args in the Kubernetes manifest as args. |
The moment I pass any arg to updater pod ex: as described here , I stop getting any logs for updater after the logs as shown below. What am I doing wrong ?
Note: I manually changes the min-replica default value in source and built the docker image. It worked fine.
The text was updated successfully, but these errors were encountered: