-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Open
Labels
area/vertical-pod-autoscalerarea/vertical-pod-autoscaler/prometheusIssues and PRs related to Vertical Pod Autoscaler history from PrometheusIssues and PRs related to Vertical Pod Autoscaler history from Prometheuskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Description
Which component are you using?:
/area vertical-pod-autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
No.
Describe the solution you'd like.:
Outline
The currently present e2e tests of the vpa-recommender do not specifically target Prometheus as storage backend. There are test(s) that explicitly validate if VPA Checkpoint resources are created, which automatically fails if we run the test(s) against a Prometheus based configuration.
Strategy
Additional implementation details can be included once the card gets picked
- Deployment manifest of a separate
prometheusinstance used by thevpa-recommender - Deployment of
kube-state-metricsthat scrape the spawned test resources- Scrape configuration in the dedicated prometheus
- Instrument existing
recommendere2e tests with labels allowing quick distinctions b/w them.
Notes
- The current e2e tests expect a
recommenderto be deployed within thekube-systemnamespace.- We can instrument the
recommendere2e tests to spawn a new per-suite namespace where to place the required recommender. ( In case we face issues deploying therecommenderwithin thekube-systemns. Running the same test against an existing cluster would also require this specific [ recommender in kube-system ns ] to be present).
- We can instrument the
Credits to @vitanovs
Describe any alternative solutions you've considered.:
N/A
Additional context.:
N/A
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/vertical-pod-autoscalerarea/vertical-pod-autoscaler/prometheusIssues and PRs related to Vertical Pod Autoscaler history from PrometheusIssues and PRs related to Vertical Pod Autoscaler history from Prometheuskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.