Skip to content

Tags are not applied to NLB post creation #1334

@davinci26

Description

@davinci26

What happened:

Apply "service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags" on a live NLB

What you expected to happen:
See the tags on the AWS console UI

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

I seems like ensureLoadBalancerv2 unlike ensureLoadBalancer doesnt have:

		{
			// Add additional tags
			klog.V(2).Infof("Creating additional load balancer tags for %s", loadBalancerName)
			tags := getKeyValuePropertiesFromAnnotation(annotations, ServiceAnnotationLoadBalancerAdditionalTags)
			if len(tags) > 0 {
				err := c.addLoadBalancerTags(loadBalancerName, tags)
				if err != nil {
					return nil, fmt.Errorf("unable to create additional load balancer tags: %v", err)
				}
			}
		}

so it doesnt apply the tags after the NLB is created

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions