Skip to content

Commit 72e3629

Browse files
scaling up SIG Node KEPs approvers
1 parent 88bcd83 commit 72e3629

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

sig-node/CONTRIBUTING.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,28 @@ touching the same code path, SIG may decide to only take one KEP for a release.
126126
Even if this is the case, properly structured KEP implementation will ensure
127127
that some progress was made for that release.
128128

129+
#### Scaling up KEP approvers
130+
131+
As per SIG charter, Tech Leads MUST Review & Approve SIG Enhancement Proposals,
132+
but MAY delegate to other contributors to fulfill these responsibilities for
133+
individual proposals. Practically, SIG Node maintain the following:
134+
135+
1. The [sig-node OWNERS in k/enhancements](https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/OWNERS#L6) contain `sig-node-tech-leads`, NOT `sig-node-leads`.
136+
**Only Tech Leads can approve the KEP to enter alpha stage.**
137+
So the alpha stage KEPs must identify one of the Tech Leads to be an approver in [kep.yaml](https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/kep.yaml#L14).
138+
2. Once the KEP implemented as alpha (implementation was actually merged),
139+
Tech Lead CAN delegate the approvership to other individual.
140+
The individual will often be an approver for some of the SIG Node component.
141+
Often one who reviewed the alpha-phase implementation of a KEP.
142+
KEP-level OWNERS file and a kep.yaml MUST be updated to reflect the additional approver.
143+
It is recommended to keep one of the Tech Leads as an approver in kep.yaml.
144+
3. It is expected to have graduation critera for beta and GA stages to be declared
145+
before the approvership of a KEP is delegated.
146+
4. If the scope of a KEP changes significantly after alpha stage,
147+
Tech Leads must be engaged in approving the scope change.
148+
Specifically, if graduation criterias are changing for one of the stages,
149+
Tech Lead needs to be notified.
150+
129151
### Helpful Links for SIG Node
130152

131153
**Code**:

0 commit comments

Comments
 (0)