Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add podReplacementPolicy and terminating field to job api #119301

Merged
merged 1 commit into from
Jul 19, 2023
Merged

add podReplacementPolicy and terminating field to job api #119301

merged 1 commit into from
Jul 19, 2023

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add API changes for https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3939-allow-replacement-when-fully-terminated.

Which issue(s) this PR fixes:

Partial Resolve kubernetes/enhancements#3939

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add podReplacementPolicy and terminating field to job api

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3939-allow-replacement-when-fully-terminated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 13, 2023
@kannon92
Copy link
Contributor Author

/sig apps

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 13, 2023
@kannon92 kannon92 mentioned this pull request Jul 13, 2023
Open
16 tasks
@kannon92
Copy link
Contributor Author

/assign @deads2k @alculquicondor @mimowo

To make the API review limited to scope I moved the api changes in #117015 to here.

alculquicondor
alculquicondor reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation.go and strategy.go should be part of this PR, as it is part of the api-review.

@alculquicondor
Copy link
Member

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jul 13, 2023
@kannon92 kannon92 force-pushed the pod-replacement-policy-job-api-only branch 2 times, most recently from b824acc to 4024063 Compare July 13, 2023 17:58
@kannon92
Copy link
Contributor Author

validation.go and strategy.go should be part of this PR, as it is part of the api-review.

Ah! I pushed up those changes.

alculquicondor
alculquicondor reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/apis/batch/validation/validation_test.go Outdated
Template: validPodTemplateSpecForGeneratedRestartPolicyNever,
Selector: validGeneratedSelector,
Template: validPodTemplateSpecForGeneratedRestartPolicyNever,
PodReplacementPolicy: &failedPodReplacement,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave this one nil (so we test that nil passes validation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I find this a bit confusing..

Do you mean leave it as:

PodReplacementPolicy: nil

or

Just drop the field entirely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are equivalent and I prefer just dropping the field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Pushed up the last of my changes.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e1e7cb8c7d6edef6063caec9f8dc2a00812c239

@kannon92 kannon92 force-pushed the pod-replacement-policy-job-api-only branch from 4024063 to 800ecc3 Compare July 13, 2023 18:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f87435739cef55272204dc6dcfdb4b0335e141b6

@alculquicondor
Copy link
Member

Implementation is approved
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@kannon92
Copy link
Contributor Author

/retest

1 similar comment
@kannon92
Copy link
Contributor Author

/retest

@pacoxu
Copy link
Member

pacoxu commented Jul 19, 2023

/skip

@Atharva-Shinde
Copy link

exception request received.
Holding for it's approval.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@kannon92
Copy link
Contributor Author

Exception was approved and release team gave me the goahead to cancel the hold. https://groups.google.com/g/kubernetes-sig-release/c/8m9_MloKhoI

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@kannon92
Copy link
Contributor Author

@Atharva-Shinde can you help with adding back the 1.28 milestone?

@Atharva-Shinde
Copy link

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 19, 2023
@kannon92 kannon92 force-pushed the pod-replacement-policy-job-api-only branch from b625dbc to ce92952 Compare July 19, 2023 16:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@kannon92
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2023 •
edited
Loading

@kannon92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-cos-alpha-features ce92952 link false /test pull-kubernetes-e2e-gce-cos-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alculquicondor
Copy link
Member

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a359ea62be68ecadf2dd4722411ae965f990855a

@k8s-ci-robot k8s-ci-robot merged commit 9892b53 into kubernetes:master Jul 19, 2023
@alexzielenski
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2023
@csuzhangxc csuzhangxc mentioned this pull request Jan 10, 2024
Merged
10 tasks
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@atiratree atiratree atiratree left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@deads2k deads2k Awaiting requested review from deads2k

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@deads2k deads2k

@mimowo mimowo

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Allow for recreation of pods once fully terminated in the job controller
10 participants
@kannon92 @alculquicondor @k8s-ci-robot @deads2k @liggitt @pacoxu @Atharva-Shinde @alexzielenski @atiratree @mimowo