Merge pull request #3068 from 08volt/user-error-constraint

fix: categorize constraint violation error as UserError

Author: k8s-ci-robot

pkg/l4/resources/user_error.go

@@ -19,6 +19,7 @@ func IsUserError(err error) bool {
 		utils.IsInvalidLoadBalancerSourceRangesSpecError(err) ||
 		utils.IsInvalidLoadBalancerSourceRangesAnnotationError(err) ||
 		utils.IsUnsupportedNetworkTierError(err) ||
+		utils.IsConstraintViolationError(err) ||
 		errors.As(err, &firewallErr) ||
 		errors.As(err, &userErr)
 }

pkg/l4/resources/user_error_test.go

@@ -2,11 +2,12 @@ package resources_test
 
 import (
 	"fmt"
+	"net/http"
 	"testing"
 
-	"k8s.io/ingress-gce/pkg/l4/resources"
-
+	"google.golang.org/api/googleapi"
 	"k8s.io/ingress-gce/pkg/firewalls"
+	"k8s.io/ingress-gce/pkg/l4/resources"
 	"k8s.io/ingress-gce/pkg/utils"
 )
 
@@ -55,6 +56,13 @@ func TestIsUserError(t *testing.T) {
 			err:  utils.NewConflictingPortsConfigurationError("8080-8090", "conflicting ports"),
 			want: true,
 		},
+		{
+			err: &googleapi.Error{
+				Code:    http.StatusPreconditionFailed,
+				Message: "Constraint constraints/compute.restrictLoadBalancerCreationForTypes violated for projects/...",
+			},
+			want: true,
+		},
 	}
 	for _, tC := range testCases {
 		tC := tC

pkg/utils/utils.go

@@ -268,6 +268,11 @@ func IsUnsupportedNetworkTierError(err error) bool {
 	return errors.As(err, &netTierError)
 }
 
+// IsConstraintViolationError checks if the error is a constraint violation error returned by GCP.
+func IsConstraintViolationError(err error) bool {
+	return IsHTTPErrorCode(err, http.StatusPreconditionFailed) && strings.Contains(err.Error(), "Constraint") && strings.Contains(err.Error(), "violated")
+}
+
 // IsIPConfigurationError checks if wrapped error is an IP configuration error.
 func IsIPConfigurationError(err error) bool {
 	var ipConfigError *IPConfigurationError

pkg/utils/utils_test.go

@@ -1867,3 +1867,53 @@ func TestLBBasedOnFinalizer(t *testing.T) {
 		})
 	}
 }
+
+func TestIsConstraintViolationError(t *testing.T) {
+	testCases := []struct {
+		desc string
+		err  error
+		want bool
+	}{
+		{
+			desc: "nil error",
+			err:  nil,
+			want: false,
+		},
+		{
+			desc: "random error",
+			err:  errors.New("random error"),
+			want: false,
+		},
+		{
+			desc: "other google api error",
+			err: &googleapi.Error{
+				Code:    http.StatusBadRequest,
+				Message: "invalid arguments",
+			},
+			want: false,
+		},
+		{
+			desc: "constraint violation google api error",
+			err: &googleapi.Error{
+				Code:    http.StatusPreconditionFailed,
+				Message: "Constraint constraints/compute.restrictLoadBalancerCreationForTypes violated for projects/cf-gcpai-sales-buddy-l-t4. Forwarding Rule projects/cf-gcpai-sales-buddy-l-t4/regions/europe-west4/forwardingRules/k8s2-tcp-mv3ejptg-anthos-identity-servic-gke-oidc-envo-eswdpmuk of type INTERNAL_TCP_UDP is not allowed.",
+			},
+			want: true,
+		},
+		{
+			desc: "status 412 but not constraint violation",
+			err: &googleapi.Error{
+				Code:    http.StatusPreconditionFailed,
+				Message: "precondition failed for some other reason",
+			},
+			want: false,
+		},
+	}
+	for _, tC := range testCases {
+		t.Run(tC.desc, func(t *testing.T) {
+			if got := utils.IsConstraintViolationError(tC.err); got != tC.want {
+				t.Errorf("IsConstraintViolationError(%v) = %v, want %v", tC.err, got, tC.want)
+			}
+		})
+	}
+}