Skip to content

Allow enable-access-log annotation to set 'access_log on' #12078

Open
@vanny96

Description

As a kubernetes cluster administrator, I'd like to set the default access_log for the ingresses to off (achieving this by using disable-access-log on the ConfigMap).
This works great, but as of right now there is no way to turn on access_log on demand for specific environments. I would have assumed that using nginx.ingress.kubernetes.io/enable-access-log: "true" would allow to set the access_log back to on, but by looking at the nginx.tmpl it looks like this annotation only takes effect when the annotation is set to false.

Would it be possible to change enable-access-log such as:

  • true: sets access_log on
  • false: sets access_log off
  • unset: sets nothing, keeps parent behaviour

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.needs-priorityneeds-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions