Skip to content

Add metrics to count requests buffered to temporary file #12895

Open
@frittentheke

Description

@frittentheke

Currently NGINX logs a warning for requests that are bigger than the configured client in-memory buffer (https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#client-body-buffer-size):

[warn] 128#128: *5837 a client request body is buffered to a temporary file /tmp/nginx/client-body/0000000097, client: 10.xx.xx.xx, server: xxxx, request: "POST /api/v1/endpoint HTTP/2.0", host: "xxx", referrer: "h [...]

While logging this per request is already really helpful to find potential optimizations, having these events counted as a Prometheus metric would be even more helpful, as this is usually used by users and allows for correlation (e.g. buffered vs. non-buffered requests, ...).

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.needs-priorityneeds-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

    Type

    No type

    Projects

    • Status

      No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions