Merge pull request #417 from mikelolasagasti/go-1.24-printf

k8s-ci-robot · web-flow · commit e7125f792ea6 · 2025-01-21T01:28:36.000-08:00
Fix: Ensure constant format strings in fmt and printf calls
diff --git a/integration_tests/internal/main.go b/integration_tests/internal/main.go
@@ -39,7 +39,7 @@ func main() {
 func getEnvOrDie(name string) string {
 	val, ok := os.LookupEnv(name)
 	if !ok {
-		fmt.Fprintf(os.Stderr, name+" could not be found in environment")
+		fmt.Fprintln(os.Stderr, name, "could not be found in environment")
 		os.Exit(1)
 	}
 	return val

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func main() {`
`39`	`39`	`func getEnvOrDie(name string) string {`
`40`	`40`	`val, ok := os.LookupEnv(name)`
`41`	`41`	`if !ok {`
`42`		`- fmt.Fprintf(os.Stderr, name+" could not be found in environment")`
	`42`	`+ fmt.Fprintln(os.Stderr, name, "could not be found in environment")`
`43`	`43`	`os.Exit(1)`
`44`	`44`	`}`
`45`	`45`	`return val`