spotinst: Bump k8s cluster controller to v2 (#16717)

* update controller v2, inform user on conflict with aws nodeTerminationHandler and Ocean

* add BuildPrune to addon,tested

* add note to release 1.31

Author: yehielnetapp

docs/releases/1.31-NOTES.md

@@ -22,6 +22,10 @@ Lorem ipsum....
 
 * TODO
 
+# Other changes of note
+
+* Spotinst cluster controller V1 is replaced with Ocean kubernetes controller V2, all old k8s resource are removed
+  except spotinst-kubernetes-cluster-controller Secret.
 
 # Breaking changes
 

pkg/model/awsmodel/spotinst.go

@@ -218,6 +218,12 @@ func (b *SpotInstanceGroupModelBuilder) buildElastigroup(c *fi.CloudupModelBuild
 	if aws := b.Cluster.Spec.CloudProvider.AWS; aws != nil {
 		group.Product = aws.SpotinstProduct
 		group.Orientation = aws.SpotinstOrientation
+		nth := aws.NodeTerminationHandler
+		if nth != nil && nth.Enabled != nil && *nth.Enabled {
+			return fmt.Errorf("can't build elastigroup while nodeTerminationHandler flag is on. " +
+				"using nodeTerminationHandler will interfere with Ocean Kubernetes controller .\n" +
+				"Please add the following configuration to cluster config \n nodeTerminationHandler:\n   enabled: false ")
+		}
 	}
 
 	// Strategy.